Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<ol> was not rendered properly if there are Chinese characters #72

Closed
hbrls opened this issue Jan 5, 2013 · 2 comments
Closed

<ol> was not rendered properly if there are Chinese characters #72

hbrls opened this issue Jan 5, 2013 · 2 comments

Comments

@hbrls
Copy link

hbrls commented Jan 5, 2013

I thought I could use this markdown format to get rendered <ol>

1. bla bla bla
2. bla bla bla

But this only works with English letters, not Chinese characters. It just ignored the 1., and rendered it as plain text like:

1. 句子 2. 句子

I initially report this issue on jekyll, and there they help to figure out that it's might be an issue with maruku, and using other markdown parser solved the problem.

I'm using markdown: redcarpet.

@bhollis
Copy link
Owner

bhollis commented Jan 5, 2013

Thanks, I'll add a test.

bhollis added a commit that referenced this issue Feb 13, 2013
@bhollis
Copy link
Owner

bhollis commented Feb 13, 2013

I've committed a passing test that shows this working on the master branch. Thanks for letting me know.

@bhollis bhollis closed this as completed Feb 13, 2013
bhollis added a commit that referenced this issue Feb 20, 2013
This removes the :li_span element type, and fixes how Maruku chooses to wrap list items in paragraphs in many cases (though not all). There are still quite a few list cases that still fail, but this fixes #26, fixes #30, fixes #64, fixes #67, and fixes #72, and activates many of the pending list tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants