Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symbolic operation in logic hashes #8

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Conversation

barthez
Copy link
Contributor

@barthez barthez commented Oct 10, 2018

Hey,

I encounter #7 while integrating json-logic-ruby in my project. I understand that apply expects a stringify_keys as this is default output from JSON.parse but input can be provided manually or it can can symbolized keys (with proper parameter to JSON.parse).

Would be great to have this feature in this gem.

Fixes #7.

@barthez
Copy link
Contributor Author

barthez commented Oct 22, 2018

Hey @bhgames, did you have a chance to take a look at it?

@bhgames
Copy link
Owner

bhgames commented Oct 22, 2018

Oh hey! I didn't even get notified about this PR. Let me take a look!

@bhgames bhgames merged commit 8ce53e0 into bhgames:master Oct 22, 2018
@bhgames
Copy link
Owner

bhgames commented Oct 22, 2018

NIce addition. Thanks for messaging me again! I think your last one got lost in my email. Sorry about the wait!

@barthez
Copy link
Contributor Author

barthez commented Oct 22, 2018

Thank you @bhgames. ❤️ 💚 💙 💛 💜

You lost the previous message, but you manage to get one on GitHub outage day. What a luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants