Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a filename attribute to the generated XML #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcomorain
Copy link

(Also add a gemspec)

@marcomorain
Copy link
Author

Hi @bhenderson – is this something you would consider merging into minitest-ci ?

@bhenderson
Copy link
Owner

hi, sorry I missed your original PR. May I ask why you want this?

also, hoe gem generates the gemspec.

@marcomorain
Copy link
Author

Hi Brian,

I'll remove the gemspec tomorrow when I get a chance.

We want to have the file name so that we can allow the user to access
failing tests quickly and easily. It will also allow us to analyse test
results better - highlight files with frequently failing tests, etc.

Marc

On Wednesday, January 7, 2015, Brian Henderson [email protected]
wrote:

hi, sorry I missed your original PR. May I ask why you want this?

also, hoe gem generates the gemspec.


Reply to this email directly or view it on GitHub
#14 (comment).

@bhenderson
Copy link
Owner

I don't have time to test this myself, can you confirm that you've built the gem and the file shows up in your ci server?

I also don't like using Dir.pwd to clean the file location, but I'm not sure what else to do.

thanks,

@stephenyeargin
Copy link

👍 for this one, if for no other reason than to not have to put this in my Gemfile, per the CircleCI docs. 😄

gem 'minitest-ci', :git => '[email protected]:circleci/minitest-ci.git'

@bhenderson
Copy link
Owner

Hi, sorry I've neglected this PR. I don't really do ruby dev any more, so I've asked circleci (in email) if they can take over the gem. I'll update here with their answer.

thank you for your interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants