Skip to content

Commit

Permalink
[8.x] [ES|QL] capitalize `FROM` in recommended queries (ela…
Browse files Browse the repository at this point in the history
…stic#205122) (elastic#205352)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] capitalize `FROM` in recommended queries
(elastic#205122)](elastic#205122)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Drew
Tate","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-02T08:30:42Z","message":"[ES|QL]
capitalize `FROM` in recommended queries (elastic#205122)\n\n##
Summary\r\n\r\n`FROM` wasn't capitalized when selected from the
menu:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/939c24b6-5ae5-417b-9dfa-fb4d411b8abc\r\n\r\n\r\n\r\nNow
it is.\r\n\r\nCo-authored-by: Stratoula Kalafateli
<[email protected]>","sha":"e5cf28bc27b6ca80c92c44a4fc805adce857b518","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.18.0"],"title":"[ES|QL]
capitalize `FROM` in recommended
queries","number":205122,"url":"https://github.com/elastic/kibana/pull/205122","mergeCommit":{"message":"[ES|QL]
capitalize `FROM` in recommended queries (elastic#205122)\n\n##
Summary\r\n\r\n`FROM` wasn't capitalized when selected from the
menu:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/939c24b6-5ae5-417b-9dfa-fb4d411b8abc\r\n\r\n\r\n\r\nNow
it is.\r\n\r\nCo-authored-by: Stratoula Kalafateli
<[email protected]>","sha":"e5cf28bc27b6ca80c92c44a4fc805adce857b518"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205122","number":205122,"mergeCommit":{"message":"[ES|QL]
capitalize `FROM` in recommended queries (elastic#205122)\n\n##
Summary\r\n\r\n`FROM` wasn't capitalized when selected from the
menu:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/939c24b6-5ae5-417b-9dfa-fb4d411b8abc\r\n\r\n\r\n\r\nNow
it is.\r\n\r\nCo-authored-by: Stratoula Kalafateli
<[email protected]>","sha":"e5cf28bc27b6ca80c92c44a4fc805adce857b518"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Drew Tate <[email protected]>
  • Loading branch information
kibanamachine and drewdaemon authored Jan 2, 2025
1 parent 60d378b commit 5fd4467
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion NOTICE.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Kibana source code with Kibana X-Pack source code
Copyright 2012-2024 Elasticsearch B.V.
Copyright 2012-2025 Elasticsearch B.V.

---
Adapted from remote-web-worker, which was available under a "MIT" license.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const ESQLMenuPopover: React.FC<ESQLMenuPopoverProps> = ({
const esqlContextMenuPanels = useMemo(() => {
const recommendedQueries = [];
if (adHocDataview && typeof adHocDataview !== 'string') {
const queryString = `from ${adHocDataview.name}`;
const queryString = `FROM ${adHocDataview.name}`;
const timeFieldName =
adHocDataview.timeFieldName ?? adHocDataview.fields?.getByType('date')?.[0]?.name;

Expand Down

0 comments on commit 5fd4467

Please sign in to comment.