Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --local option to Bismark tool #1537

Closed
wants to merge 1 commit into from

Conversation

jonasbucherETH
Copy link

This pull request adds the --local option to the Bismark alignment tool in Galaxy.

Changes:

  • Added a boolean parameter local to enable the --local option.
  • Updated bismark_bowtie2_wrapper.xml to include the new parameter and updated the command section.
  • Modified bismark_wrapper.py to handle the --local option when constructing the command line.

Copy link
Owner

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jonasbucherETH!

Github actions do face some problems atm https://www.githubstatus.com/

Do you think we should also bump the requirement versions? e.g. the bowtie2 version and samtools?

@jonasbucherETH
Copy link
Author

I updated the requirement versions in the bismark_bowtie2_wrapper.xml. The linting seems to fail for other parts of bismark (for example bismark_methylation_extractor), should I update these as well to pass the required statuses and checks?

@bgruening
Copy link
Owner

@jonasbucherETH that would be great! Our linting gets stricter over time, but we are improving the quality with that. Thanks for you help!

Please also bump then the version number of the other tools.

@jonasbucherETH
Copy link
Author

It seems I accidentally closed the request, is there a way to reopen it? Otherwise I will create a new one.

@bgruening
Copy link
Owner

Usually I can reopen them, but not in this case ... strange.

@bgruening
Copy link
Owner

Can it be that you deleted your branch?

@jonasbucherETH
Copy link
Author

No, I think it is because I did a force-push, not realizing that this would mess with the pull request.

@bgruening
Copy link
Owner

Upps, sorry! Can I help in any way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants