Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing lint issue on minipolish.xml xref update | reago(update complete) #1344

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

J-Swang
Copy link

@J-Swang J-Swang commented Oct 31, 2023

No description provided.

@bgruening
Copy link
Owner

The linter says:

.. WARNING: Best practice violation [xrefs] elements should come before [requirements]

Can you change this please?

@J-Swang
Copy link
Author

J-Swang commented Nov 2, 2023

I changed both minipolish.xml and macros.xml cause I wasn't which is the right fix for this.

@J-Swang J-Swang changed the title Add bio.tools id for reago Fixing lint issue on minipolish.xml xref update | reago(update complete) Nov 2, 2023
@bgruening
Copy link
Owner

For minipolish you could just move the <expand macro="biotools"/> up to that it comes before the requirements expand. And then revert your last commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants