Replace docker_port with proxy_prefix #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
bgruening
added a commit
that referenced
this pull request
Oct 6, 2015
Replace docker_port with proxy_prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we replace the DOCKER_PORT which had been used to separate users trying to access a given notebook through the proxy, with just relying on the proxy to do it automatically. This simplifies our configuration nicely, and makes the URLs more friendly. Instead of
/ipython/#####/treewe get$proxy_prefix/ipython/treewhere$proxy_prefixis the completely optional URL prefix.Here is the companion PR in Galaxy, and similar code is in branch 15.10 of the rstudio image.