Refactoring of the 4626 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* storage refactored to OZ like, added comments to errors, fixed try-catch with permit * TestnetProcedures is deleted * remove aave-v3-origin dependencies * BUSL license --------- Co-authored-by: Pavel Menshikov <[email protected]>
* initial commit without exchange rate * moved to OZ finally + added virtual assets counting * add decimalsOffset = 3 + fixed tests, cause shares were messed with assets * little fixes + commented 1 test * removed forge-std * change AC model to ownable, make permissioned methods virtual * tests are fixed after deleting slashingAdmin and ACLManager * Refactoring of _update on ERC4626StakeTokenUpgradeable (#41) * dependencies are sorted like like oz-up, oz, our * optimized _update + added event * renamed IStakeToken to IERC4626StakeToken as made in stata + license updated + inheritdoc inserted * little fix * micro opt * Rescuable returned * added test for non-admins fuzz * Tests added * Docs are added * Grammar fixed * non-admin tests fixed * precision losses are added into the limitations p * little foundry fix * Update LICENSE Co-authored-by: Andrey <[email protected]> * Update README.md Co-authored-by: Andrey <[email protected]> * Update tests/Rescuable.t.sol Co-authored-by: Andrey <[email protected]> * deleted excess function * add comment --------- Co-authored-by: Pavel Menshikov <[email protected]> Co-authored-by: Andrei Kozlov <[email protected]>
sakulstra
reviewed
Aug 26, 2024
Co-authored-by: Lukas <[email protected]>
Co-authored-by: Lukas <[email protected]>
sakulstra
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.