Changing the order of actions with updating totalAssets()

bgd-labs · Sep 6, 2024 · 2530d83 · 2530d83
1 parent 22f53dc
commit 2530d83
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/contracts/extension/ERC4626StakeTokenUpgradeable.sol b/src/contracts/extension/ERC4626StakeTokenUpgradeable.sol
@@ -159,9 +159,9 @@ abstract contract ERC4626StakeTokenUpgradeable is
     uint256 assets,
     uint256 shares
   ) internal override {
-    _getStakeTokenStorage()._totalAssets += assets.toUint192();
-
     super._deposit(caller, receiver, assets, shares);
+
+    _getStakeTokenStorage()._totalAssets += assets.toUint192();
   }
 
   function _withdraw(
@@ -171,9 +171,9 @@ abstract contract ERC4626StakeTokenUpgradeable is
     uint256 assets,
     uint256 shares
   ) internal override {
-    _getStakeTokenStorage()._totalAssets -= assets.toUint192();
-
     super._withdraw(caller, receiver, owner, assets, shares);
+
+    _getStakeTokenStorage()._totalAssets -= assets.toUint192();
   }
 
   function _cooldown(address from) internal virtual {