Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Onboard AUSD Aave v3 Avalanche #530

Merged
merged 15 commits into from
Dec 23, 2024
Merged

✨ Onboard AUSD Aave v3 Avalanche #530

merged 15 commits into from
Dec 23, 2024

Conversation

MartinGbz
Copy link
Contributor

@MartinGbz MartinGbz commented Nov 25, 2024 •
edited
Loading

I've added a transfer of the seed amount from the Collector to the Executor, because an error has been done in the transfer of the seed funds.

@MartinGbz MartinGbz force-pushed the feat/add-ausd-aave-v3-avalanche branch from f64e227 to b21f828 Compare November 25, 2024 13:41
@MartinGbz MartinGbz marked this pull request as ready for review November 27, 2024 11:06
@sakulstra
Copy link
Contributor

The risk assessment by us is still pending on this one and probably needs a capo feed.
Will get back to you once i got news on the topic.

@MartinGbz
Copy link
Contributor Author

@sakulstra Okay np, thanks for the info

Just have a question, I got a weird error on the test_defaultProposalExecution test.
[FAIL: revert: stdStorage find(StdStorage): Failed to write value.] => it seems to be an error with deal() from foundry

I didn't have this error before, and I still don't have this error in other AIP PRs.
I tried forge install, forge update, forge build --force, forge clean... etc, but still have the issue.

Any idea?

@sakulstra
Copy link
Contributor

@MartinGbz didn't yet check but probably AUSD does some fancy things on _balances storage.
Foundry deal essentially checks if it's a uint and if not reverts.
We maintain a list of tokens here: https://github.com/bgd-labs/aave-helpers/blob/master/src/CommonTestBase.sol#L45 that cannot be dealt.

@MartinGbz
Copy link
Contributor Author

@sakulstra Thanks for this, now it works like a charm. The lib is updated, test are passing, the PR is ready for a review.

@MartinGbz
Copy link
Contributor Author

The oracle has been update for the new CAPO one: https://snowtrace.io/address/0x83f32c0882B12Ef16214c417efF11FD9e764bf34

@sakulstra sakulstra merged commit b368d23 into bgd-labs:main Dec 23, 2024
DhairyaSethi pushed a commit to aave/aave-proposals-v3 that referenced this pull request Dec 25, 2024
@MartinGbz @Rozengarden @DhairyaSethi
✨ Onboard AUSD Aave v3 Avalanche (bgd-labs#530)
ef5030b 
* feat: USDS BR update

* ✨ add ausd aave v3 avalanche

* ✨ update md file

* 🐛 fix AUSD_LM_ADMIN

* Revert "feat: USDS BR update"

This reverts commit 4fda313.

* 🐛 fix Collateral Enabled md to false

* 🔧 change seed amount for 100 AUSD

* ✨ generate test + fix issue wrong collector transfer

* ⬆️ update aave-helpers lib

* ✅ test passed + update diff

* Revert "⬆️ update aave-helpers lib"

This reverts commit b4b5022.

* 🔥 revert lib update

* 🐛 update chainlink price feed for capo

---------

Co-authored-by: Rozengarden <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TepNik TepNik TepNik approved these changes

@sakulstra sakulstra sakulstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinGbz @sakulstra @TepNik @Rozengarden