feat: additional functionality for the generator #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by passing the -u/--update flag when using the -c options the cached block height will get updated
sakulstra
added a commit
that referenced
this pull request
Nov 19, 2024
* feat: additional functionality for the generator (#484) by passing the -u/--update flag when using the -c options the cached block height will get updated * fix: bump deps * fix: update helpers * fix: update actions * fix: update readme --------- Co-authored-by: Alice <[email protected]>
DhairyaSethi
pushed a commit
to aave/aave-proposals-v3
that referenced
this pull request
Dec 25, 2024
…labs#525) * feat: additional functionality for the generator (bgd-labs#484) by passing the -u/--update flag when using the -c options the cached block height will get updated * fix: bump deps * fix: update helpers * fix: update actions * fix: update readme --------- Co-authored-by: Alice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by passing the -u/--update flag when using the -c options the cached block height will get updated
Updating the block height for the test is actually something I end up doing manually from time to time
(e.g. after funding the collector for assets listing, when Aave get an update, etc)
And I actually lost a lot of time today because I forgot to do it. So in the off chance am not the only one am presenting this PR.
let me know if u have any feedback.