Set aci emission manager Avalanche Network - Review #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marczeller
changed the title
sendra
reviewed
Jun 21, 2024
| @@ -0,0 +1,33 @@ | |||
| --- | |||
| title: "Set ACI as Emission Manager for wAVAX on the Avalanche network" | |||
There was a problem hiding this comment.
missing ggAVAX & sAVAX on titles
sakulstra
previously approved these changes
Jun 21, 2024
sendra
approved these changes
Jun 21, 2024
|
Foundry report forge 0.2.0 (d7eac74 2024-06-21T00:16:53.812858792Z)Build logCompiling 409 files with Solc 0.8.19
Solc 0.8.19 finished in 207.67s
Compiler run successful with warnings:
Warning (3628): This contract has a payable fallback function, but no receive ether function. Consider adding a receive ether function.
--> src/20240502_AaveV1Ethereum_AaveV1Deprecation/AaveV1Ethereum_AaveV1Deprecation_20240502.t.sol:94:1:
|
94 | contract AaveV1Ethereum_AaveV1Deprecation_20240502_Test is ProtocolV3TestBase {
| ^ (Relevant source part starts here and spans across multiple lines).
Note: The payable fallback function is defined here.
--> src/20240502_AaveV1Ethereum_AaveV1Deprecation/AaveV1Ethereum_AaveV1Deprecation_20240502.t.sol:297:3:
|
297 | fallback() external payable {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| Contract | Size (B) | Margin (B) |
|-------------------------------------------------------------------------------|----------|------------|
| AaveGovernanceV2 | 45 | 24,531 |
| AaveSafetyModule | 45 | 24,531 |
| AaveSwapper | 5,572 | 19,004 |
| AaveV1 | 45 | 24,531 |
| AaveV1Ethereum_AaveV1Deprecation_20240502 | 2,593 | 21,983 |
| AaveV2Avalanche | 45 | 24,531 |
| AaveV2AvalancheAssets | 45 | 24,531 |
| AaveV2Avalanche_LTLTVReductionsOnAaveV2Stablecoins_20240510 | 210 | 24,366 |
| AaveV2Avalanche_MigrateRobotsToChainlinkAutomationV2_20240422 | 518 | 24,058 |
| AaveV2Avalanche_ReserveFactorUpgrades_20240506 | 1,022 | 23,554 |
| AaveV2Avalanche_ReserveFactorUpgrades_20240524 | 1,022 | 23,554 |
| AaveV2Avalanche_StablecoinIRUpdates_20240424 | 1,858 | 22,718 |
| AaveV2Avalanche_TemporaryFreezeOfLongTailV2Assets_20240418 | 186 | 24,390 |
| AaveV2Ethereum | 45 | 24,531 |
| AaveV2EthereumAMM | 45 | 24,531 |
| AaveV2EthereumAMMAssets | 45 | 24,531 |
| AaveV2EthereumAssets | 45 | 24,531 |
| AaveV2Ethereum_AAMPLSecondDistribution_20240429 | 2,370 | 22,206 |
| AaveV2Ethereum_AprilFinanceUpdate_20240421 | 7,897 | 16,679 |
| AaveV2Ethereum_ChaosLabsEthereumV2LTReductions_20240509 | 358 | 24,218 |
| AaveV2Ethereum_DeprecationOfSmallCapStablecoinsOnV2Ethereum_20240502 | 3,472 | 21,104 |
| AaveV2Ethereum_LTLTVReductionsOnAaveV2Stablecoins_20240510 | 210 | 24,366 |
| AaveV2Ethereum_ReserveFactorUpgrades_20240506 | 1,778 | 22,798 |
| AaveV2Ethereum_ReserveFactorUpgrades_20240524 | 1,778 | 22,798 |
| AaveV2Ethereum_StablecoinIRUpdates_20240424 | 1,858 | 22,718 |
| AaveV2Ethereum_TemporaryFreezeOfLongTailV2Assets_20240418 | 793 | 23,783 |
| AaveV2Polygon | 45 | 24,531 |
| AaveV2PolygonAssets | 45 | 24,531 |
| AaveV2Polygon_AprilFinanceUpdate_20240421 | 6,129 | 18,447 |
| AaveV2Polygon_AprilFinanceUpdate_20240421_PartB | 451 | 24,125 |
| AaveV2Polygon_LTLTVReductionsOnAaveV2Stablecoins_20240510 | 210 | 24,366 |
| AaveV2Polygon_MigrateRobotsToChainlinkAutomationV2_20240422 | 518 | 24,058 |
| AaveV2Polygon_TemporaryFreezeOfLongTailV2Assets_20240418 | 186 | 24,390 |
| AaveV3Arbitrum | 45 | 24,531 |
| AaveV3ArbitrumAssets | 45 | 24,531 |
| AaveV3ArbitrumEModes | 45 | 24,531 |
| AaveV3Arbitrum_AdjustingInterestRateCurveForWeETHOnArbitrum_20240603 | 3,923 | 20,653 |
| AaveV3Arbitrum_ChaosLabsRiskParameterUpdatesAaveV3_20240530 | 3,376 | 21,200 |
| AaveV3Arbitrum_GHOCrossChainLaunch_20240528 | 14,274 | 10,302 |
| AaveV3Arbitrum_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,669 | 20,907 |
| AaveV3Arbitrum_MigrateRobotsToChainlinkAutomationV2_20240422 | 2,954 | 21,622 |
| AaveV3Arbitrum_OptimizeETHCorrelatedAssetParameters_20240612 | 3,622 | 20,954 |
| AaveV3Arbitrum_SetACIAsEmissionManager_20240620 | 285 | 24,291 |
| AaveV3Arbitrum_StablecoinIRUpdates_20240424 | 5,381 | 19,195 |
| AaveV3Avalanche | 45 | 24,531 |
| AaveV3AvalancheAssets | 45 | 24,531 |
| AaveV3AvalancheEModes | 45 | 24,531 |
| AaveV3Avalanche_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,377 | 21,199 |
| AaveV3Avalanche_MigrateRobotsToChainlinkAutomationV2_20240422 | 3,577 | 20,999 |
| AaveV3Avalanche_OptimizeETHCorrelatedAssetParameters_20240612 | 3,623 | 20,953 |
| AaveV3Avalanche_SetACIAsEmissionManagerForWAVAXOnTheAvalancheNetwork_20240620 | 615 | 23,961 |
| AaveV3Avalanche_StablecoinIRUpdates_20240424 | 4,628 | 19,948 |
| AaveV3BNB | 45 | 24,531 |
| AaveV3BNBAssets | 45 | 24,531 |
| AaveV3BNBEModes | 45 | 24,531 |
| AaveV3BNB_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,528 | 21,048 |
| AaveV3BNB_OptimizeETHCorrelatedAssetParameters_20240612 | 3,629 | 20,947 |
| AaveV3BNB_StablecoinIRUpdates_20240424 | 4,132 | 20,444 |
| AaveV3Base | 45 | 24,531 |
| AaveV3BaseAssets | 45 | 24,531 |
| AaveV3BaseEModes | 45 | 24,531 |
| AaveV3Base_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,517 | 21,059 |
| AaveV3Base_OptimizeETHCorrelatedAssetParameters_20240612 | 3,605 | 20,971 |
| AaveV3Base_StablecoinIRUpdates_20240424 | 3,868 | 20,708 |
| AaveV3Base_WeETHAaveV3BaseOnboarding_20240527 | 4,997 | 19,579 |
| AaveV3Ethereum | 45 | 24,531 |
| AaveV3EthereumAssets | 45 | 24,531 |
| AaveV3EthereumEModes | 45 | 24,531 |
| AaveV3Ethereum_ACIAdAstra_20240506 | 835 | 23,741 |
| AaveV3Ethereum_AaveV31CantinaCompetition_20240503 | 344 | 24,232 |
| AaveV3Ethereum_AprilFinanceUpdatePartB_20240515 | 4,488 | 20,088 |
| AaveV3Ethereum_GHOCrossChainLaunch_20240528 | 18,000 | 6,576 |
| AaveV3Ethereum_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,669 | 20,907 |
| AaveV3Ethereum_GhoStewardUpdate_20240602 | 2,571 | 22,005 |
| AaveV3Ethereum_LlamariskRiskProvider_20240421 | 641 | 23,935 |
| AaveV3Ethereum_MigrateRobotsToChainlinkAutomationV2_20240422 | 5,800 | 18,776 |
| AaveV3Ethereum_OnboardUSDeAaveV3Ethereum_20240528 | 5,012 | 19,564 |
| AaveV3Ethereum_OnboardingETHxToAaveV3_20240521 | 5,000 | 19,576 |
| AaveV3Ethereum_OptimizeETHCorrelatedAssetParameters_20240612 | 3,622 | 20,954 |
| AaveV3Ethereum_OrbitProgramRenewal_20240513 | 1,670 | 22,906 |
| AaveV3Ethereum_SetACIAsEmissionManager_20240620 | 323 | 24,253 |
| AaveV3Ethereum_StablecoinIRUpdates_20240424 | 5,130 | 19,446 |
| AaveV3Ethereum_StkGHOIncentives_20240424 | 1,476 | 23,100 |
| AaveV3Ethereum_UpdatingWeETHRiskParameters_20240426 | 4,111 | 20,465 |
| AaveV3Gnosis | 45 | 24,531 |
| AaveV3GnosisAssets | 45 | 24,531 |
| AaveV3GnosisEModes | 45 | 24,531 |
| AaveV3Gnosis_AprilFinanceUpdate_20240421 | 380 | 24,196 |
| AaveV3Gnosis_ChaosLabsRiskParameterUpdatesAaveV3_20240530 | 3,374 | 21,202 |
| AaveV3Gnosis_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,519 | 21,057 |
| AaveV3Gnosis_OptimizeETHCorrelatedAssetParameters_20240612 | 3,620 | 20,956 |
| AaveV3Gnosis_StablecoinIRUpdates_20240424 | 4,123 | 20,453 |
| AaveV3Metis | 45 | 24,531 |
| AaveV3MetisAssets | 45 | 24,531 |
| AaveV3MetisEModes | 45 | 24,531 |
| AaveV3Metis_OptimizeETHCorrelatedAssetParameters_20240612 | 3,606 | 20,970 |
| AaveV3Optimism | 45 | 24,531 |
| AaveV3OptimismAssets | 45 | 24,531 |
| AaveV3OptimismEModes | 45 | 24,531 |
| AaveV3Optimism_ChaosLabsParameterRecommendationsSUSDOnV3Optimism_20240528 | 3,973 | 20,603 |
| AaveV3Optimism_ChaosLabsRiskParameterUpdatesAaveV3_20240530 | 3,363 | 21,213 |
| AaveV3Optimism_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,669 | 20,907 |
| AaveV3Optimism_MigrateRobotsToChainlinkAutomationV2_20240422 | 2,844 | 21,732 |
| AaveV3Optimism_OptimizeETHCorrelatedAssetParameters_20240612 | 3,609 | 20,967 |
| AaveV3Optimism_SUSDRiskParametersUpdate_20240517 | 3,372 | 21,204 |
| AaveV3Optimism_StablecoinIRUpdates_20240424 | 5,130 | 19,446 |
| AaveV3Polygon | 45 | 24,531 |
| AaveV3PolygonAssets | 45 | 24,531 |
| AaveV3PolygonEModes | 45 | 24,531 |
| AaveV3Polygon_ChaosLabsRiskParameterUpdatesAaveV3_20240530 | 3,520 | 21,056 |
| AaveV3Polygon_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,668 | 20,908 |
| AaveV3Polygon_MigrateRobotsToChainlinkAutomationV2_20240422 | 2,773 | 21,803 |
| AaveV3Polygon_OptimizeETHCorrelatedAssetParameters_20240612 | 3,621 | 20,955 |
| AaveV3Polygon_StablecoinIRUpdates_20240424 | 5,380 | 19,196 |
| AaveV3Scroll | 45 | 24,531 |
| AaveV3ScrollAssets | 45 | 24,531 |
| AaveV3ScrollEModes | 45 | 24,531 |
| AaveV3Scroll_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,374 | 21,202 |
| AaveV3Scroll_OptimizeETHCorrelatedAssetParameters_20240612 | 3,607 | 20,969 |
| AaveV3Scroll_StablecoinIRUpdates_20240424 | 3,620 | 20,956 |
| Address | 45 | 24,531 |
| AggregateRateLimiter | 1,931 | 22,645 |
| CallWithExactGas | 45 | 24,531 |
| ChainHelpers | 45 | 24,531 |
| ChainIds | 45 | 24,531 |
| Client | 111 | 24,465 |
| ConfiguratorInputTypes | 45 | 24,531 |
| ConfirmedOwner | 552 | 24,024 |
| ConfirmedOwnerWithProposal | 552 | 24,024 |
| Create2Utils | 123 | 24,453 |
| DataTypes | 45 | 24,531 |
| ERC165Checker | 45 | 24,531 |
| ERC1967Proxy | 136 | 24,440 |
| EVM2EVMOffRamp | 19,826 | 4,750 |
| EVM2EVMOnRamp | 20,900 | 3,676 |
| EngineFlags | 45 | 24,531 |
| EnumerableMap | 45 | 24,531 |
| EnumerableMapAddresses | 45 | 24,531 |
| EnumerableSet | 45 | 24,531 |
| Errors | 4,673 | 19,903 |
| GovV3Helpers | 2,581 | 21,995 |
| GovV3StorageHelpers | 45 | 24,531 |
| GovernanceV3Arbitrum | 45 | 24,531 |
| GovernanceV3Avalanche | 45 | 24,531 |
| GovernanceV3BNB | 45 | 24,531 |
| GovernanceV3Base | 45 | 24,531 |
| GovernanceV3Ethereum | 45 | 24,531 |
| GovernanceV3Gnosis | 45 | 24,531 |
| GovernanceV3Metis | 45 | 24,531 |
| GovernanceV3Optimism | 45 | 24,531 |
| GovernanceV3Polygon | 45 | 24,531 |
| GovernanceV3PolygonZkEvm | 45 | 24,531 |
| GovernanceV3Scroll | 45 | 24,531 |
| Internal | 147 | 24,429 |
| IpfsUtils | 45 | 24,531 |
| Math | 45 | 24,531 |
| MerkleMultiProof | 45 | 24,531 |
| MiscArbitrum | 45 | 24,531 |
| MiscEthereum | 45 | 24,531 |
| MiscPolygon | 45 | 24,531 |
| OrbitProgramData | 422 | 24,154 |
| OwnerIsCreator | 552 | 24,024 |
| PayloadsControllerUtils | 45 | 24,531 |
| PriceRegistry | 5,352 | 19,224 |
| ProxyHelpers | 45 | 24,531 |
| RateLimiter | 45 | 24,531 |
| ReserveConfiguration | 130 | 24,446 |
| RewardsDataTypes | 45 | 24,531 |
| Router | 8,873 | 15,703 |
| SafeCast | 45 | 24,531 |
| SafeERC20 | 45 | 24,531 |
| StorageHelpers | 45 | 24,531 |
| StorageSlot | 45 | 24,531 |
| Strings | 45 | 24,531 |
| TransparentUpgradeableProxy | 2,040 | 22,536 |
| USDPriceWith18Decimals | 45 | 24,531 |
| UpgradeableBurnMintTokenPool | 9,831 | 14,745 |
| UpgradeableGhoToken | 8,597 | 15,979 |
| UpgradeableLockReleaseTokenPool | 12,076 | 12,500 |
| Utils | 15,014 | 9,562 |
| WadRayMath | 45 | 24,531 |Test success 🌈No files changed, compilation skipped
Ran 1 test for src/20240620_AaveV3Avalanche_SetACIAsEmissionManagerForWAVAXOnTheAvalancheNetwork/AaveV3Avalanche_SetACIAsEmissionManagerForWAVAXOnTheAvalancheNetwork_20240620.t.sol:AaveV3Avalanche_SetACIAsEmissionManagerForWAVAXOnTheAvalancheNetwork_20240620_Test
[PASS] test_defaultProposalExecution() (gas: 39607408)
Logs:
0xd586E7F844cEa2F87f50152665BCbc2C279D8d70
0x5947BB275c521040051D82396192181b413227A3
0xB97EF9Ef8734C71904D8002F8b6Bc66Dd9c48a6E
0x50b7545627a5162F82A992c33b87aDc75187B218
0x49D5c2BdFfac6CE2BFdB6640F4F80f226bc10bAB
0x9702230A8Ea53601f5cD2dc00fDBc13d4dF4A8c7
0xB31f66AA3C1e785363F0875A1B74E27b85FD66c7
0xD24C2Ad096400B6FBcd2ad8B24E7acBc21A1da64
0x5c49b268c9841AFF1Cc3B0a418ff5c3442eE3F3b
0x152b9d0FdC40C096757F570A51E494bd4b943E50
E2E: Collateral DAI.e, TestAsset DAI.e
SUPPLY: DAI.e, Amount: 100014478095849155123695
SUPPLY: DAI.e, Amount: 1000144780958491551236
WITHDRAW: DAI.e, Amount: 500072390479245775618
WITHDRAW: DAI.e, Amount: 500072390479245775618
BORROW: DAI.e, Amount 1000144780958491551236, Stable: false
REPAY: DAI.e, Amount: 1000144780958491551236
E2E: Collateral DAI.e, TestAsset LINK.e
SUPPLY: DAI.e, Amount: 100014478095849155123695
SUPPLY: LINK.e, Amount: 69774641743480017276
WITHDRAW: LINK.e, Amount: 34887320871740008638
WITHDRAW: LINK.e, Amount: 34887320871740008638
BORROW: LINK.e, Amount 69774641743480017276, Stable: false
REPAY: LINK.e, Amount: 69774641743480017276
E2E: Collateral DAI.e, TestAsset USDC
SUPPLY: DAI.e, Amount: 100014478095849155123695
SUPPLY: USDC, Amount: 999982630
WITHDRAW: USDC, Amount: 499991315
WITHDRAW: USDC, Amount: 499991315
BORROW: USDC, Amount 999982630, Stable: false
REPAY: USDC, Amount: 999982630
E2E: TestAsset WBTC.e SKIPPED
E2E: Collateral DAI.e, TestAsset WETH.e
SUPPLY: DAI.e, Amount: 100014478095849155123695
SUPPLY: WETH.e, Amount: 284557718216857842
WITHDRAW: WETH.e, Amount: 142278859108428921
WITHDRAW: WETH.e, Amount: 142278859108428920
BORROW: WETH.e, Amount 284557718216857842, Stable: false
REPAY: WETH.e, Amount: 284557718216857842
E2E: Collateral DAI.e, TestAsset USDt
SUPPLY: DAI.e, Amount: 100014478095849155123695
SUPPLY: USDt, Amount: 1000247081
WITHDRAW: USDt, Amount: 500123540
WITHDRAW: USDt, Amount: 500123541
BORROW: USDt, Amount 1000247081, Stable: false
REPAY: USDt, Amount: 1000247081
E2E: Collateral DAI.e, TestAsset AAVE.e
SUPPLY: DAI.e, Amount: 100014478095849155123695
SUPPLY: AAVE.e, Amount: 11746864410246519083
WITHDRAW: AAVE.e, Amount: 5873432205123259541
WITHDRAW: AAVE.e, Amount: 5873432205123259542
E2E: Collateral DAI.e, TestAsset WAVAX
SUPPLY: DAI.e, Amount: 100014478095849155123695
SUPPLY: WAVAX, Amount: 36192544335866811436
WITHDRAW: WAVAX, Amount: 18096272167933405718
WITHDRAW: WAVAX, Amount: 18096272167933405718
BORROW: WAVAX, Amount 36192544335866811436, Stable: false
REPAY: WAVAX, Amount: 36192544335866811436
E2E: Collateral DAI.e, TestAsset sAVAX
SUPPLY: DAI.e, Amount: 100014478095849155123695
SUPPLY: sAVAX, Amount: 31399319808780717108
WITHDRAW: sAVAX, Amount: 15699659904390358554
WITHDRAW: sAVAX, Amount: 15699659904390358554
E2E: Collateral DAI.e, TestAsset FRAX
SUPPLY: DAI.e, Amount: 100014478095849155123695
SUPPLY: FRAX, Amount: 1002078300374193072690
WITHDRAW: FRAX, Amount: 501039150187096536345
WITHDRAW: FRAX, Amount: 501039150187096536346
BORROW: FRAX, Amount 1002078300374193072690, Stable: false
REPAY: FRAX, Amount: 1002078300374193072690
E2E: TestAsset MAI SKIPPED
E2E: Collateral DAI.e, TestAsset BTC.b
SUPPLY: DAI.e, Amount: 100014478095849155123695
SUPPLY: BTC.b, Amount: 1538549
WITHDRAW: BTC.b, Amount: 769274
WITHDRAW: BTC.b, Amount: 769274
BORROW: BTC.b, Amount 1538549, Stable: false
REPAY: BTC.b, Amount: 1538549
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 48.50s (48.08s CPU time)
Ran 1 test suite in 48.51s (48.50s CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.