Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typos #254

Merged
merged 1 commit into from
Feb 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/GovHelpers.sol
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ library GovHelpers {
return true;
if (executor == AaveGovernanceV2.BASE_BRIDGE_EXECUTOR && block.chainid == ChainIds.BASE)
return true;
// not a l2, but following same interface & stroage
// not a l2, but following same interface & storage
if (executor == AaveGovernanceV2.ARC_TIMELOCK && block.chainid == ChainIds.MAINNET) return true;
return false;
}
Expand Down
10 changes: 5 additions & 5 deletions src/GovV3Helpers.sol
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ library GovV3Helpers {
* @param payloadAddress address of the payload to be executed
* @param accessLevel accessLevel required by the payload
* @param value eth value to be sent to the payload
* @param withDelegateCall determines if payload thould be executed via delgatecall
* @param withDelegateCall determines if payload should be executed via delgatecall
* @param signature signature to be executed on the payload
* @param callData calldata for the signature
*/
Expand Down Expand Up @@ -283,7 +283,7 @@ library GovV3Helpers {

/**
* @dev executes a payloadAddress via payloadsController by injecting it into storage and executing it afterwards.
* Injecting into storage is a convinience method to reduce the txs executed from 2 to 1, this allows awaiting emitted events on the payloadsController.
* Injecting into storage is a convenience method to reduce the txs executed from 2 to 1, this allows awaiting emitted events on the payloadsController.
* @notice This method is for test purposes only.
* @param vm Vm
* @param payloadAddress address of the payload to execute
Expand Down Expand Up @@ -578,7 +578,7 @@ library GovV3Helpers {
}

/**
* @dev Executes an already created proposal on governance v3 by manipulating stororage so it#s executable in the current block.
* @dev Executes an already created proposal on governance v3 by manipulating storage so it#s executable in the current block.
* @param vm Vm
* @param proposalId id of the proposal to execute
*/
Expand Down Expand Up @@ -779,7 +779,7 @@ library GovV3Helpers {
IPayloadsControllerCore.ExecutionAction[] memory actionsA,
IPayloadsControllerCore.ExecutionAction[] memory actionsB
) private pure returns (bool) {
// must be equal size for equlity
// must be equal size for equality
if (actionsA.length != actionsB.length) return false;
for (uint256 actionId = 0; actionId < actionsA.length; actionId++) {
if (actionsA[actionId].target != actionsB[actionId].target) return false;
Expand Down Expand Up @@ -855,7 +855,7 @@ library GovV3StorageHelpers {
bytes32(PROPOSALS_COUNT_SLOT),
bytes32(uint256(count + 1))
);
// overwrite creator as creator porposition power is checked on execution
// overwrite creator as creator proposition power is checked on execution
vm.store(
address(GovernanceV3Ethereum.GOVERNANCE),
bytes32(proposalBaseSlot + 1),
Expand Down
6 changes: 3 additions & 3 deletions src/ProtocolV3TestBase.sol
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ contract ProtocolV3TestBase is CommonTestBase {
) public view {
uint256 configsBeforeLength = configBefore.length;
for (uint256 i = 0; i < configAfter.length; i++) {
// assets are ususally not permanently unlisted, so the expectation is there will only be addition
// assets are usually not permanently unlisted, so the expectation is there will only be addition
// if config existed before
if (i < configsBeforeLength) {
// borrow increase should only happen on assets with borrowing enabled
Expand All @@ -129,7 +129,7 @@ contract ProtocolV3TestBase is CommonTestBase {
// borrow cap should never exceed supply cap
if (
configAfter[i].borrowCap != 0 &&
configAfter[i].underlying != AaveV3EthereumAssets.GHO_UNDERLYING // GHO is the exlcusion from the rule
configAfter[i].underlying != AaveV3EthereumAssets.GHO_UNDERLYING // GHO is the exclusion from the rule
) {
console.log(configAfter[i].underlying);
require(configAfter[i].borrowCap <= configAfter[i].supplyCap, 'PL_SUPPLY_LT_BORROW');
Expand All @@ -140,7 +140,7 @@ contract ProtocolV3TestBase is CommonTestBase {
/**
* @dev Generates a markdown compatible snapshot of the whole pool configuration into `/reports`.
* @param reportName filename suffix for the generated reports.
* @param pool the pool to be snapshotted
* @param pool the pool to be snapshot
* @return ReserveConfig[] list of configs
*/
function createConfigurationSnapshot(
Expand Down
2 changes: 1 addition & 1 deletion src/asset-manager/interfaces/IWardenBoost.sol
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ interface IWardenBoost {
function offers(uint256 boostId) external returns (BoostOffer memory);

/// @notice Registers a new user wanting to sell its delegation
/// @dev Regsiters a new user, creates a BoostOffer with the given parameters
/// @dev Registers a new user, creates a BoostOffer with the given parameters
/// @param pricePerVote Price of 1 vote per second (in wei)
/// @param maxDuration Maximum duration (in weeks) that a Boost can last when taken from this Offer
/// @param expiryTime Timestamp when this Offer is not longer valid
Expand Down
4 changes: 2 additions & 2 deletions src/riskstewards/ICapsPlusRiskSteward.sol
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {IAaveV3ConfigEngine} from '../v3-config-engine/IAaveV3ConfigEngine.sol';
*/
interface ICapsPlusRiskSteward {
/**
* @notice Stuct storing the last update of a specific cap
* @notice Struct storing the last update of a specific cap
*/
struct Debounce {
uint40 supplyCapLastUpdated;
Expand Down Expand Up @@ -41,7 +41,7 @@ interface ICapsPlusRiskSteward {
function RISK_COUNCIL() external view returns (address);

/**
* @notice Allows increasing borrow and supply caps accross multiple assets
* @notice Allows increasing borrow and supply caps across multiple assets
* @dev A cap increase is only possible ever 5 days per asset
* @dev A cap increase is only allowed to increase the cap by 50%
* @param capUpdates caps to be updated
Expand Down
4 changes: 2 additions & 2 deletions src/v2-config-engine/AaveV2Payload.sol
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ abstract contract AaveV2Payload {
LISTING_ENGINE = engine;
}

/// @dev to be overriden on the child if any extra logic is needed pre-listing
/// @dev to be overridden on the child if any extra logic is needed pre-listing
function _preExecute() internal virtual {}

/// @dev to be overriden on the child if any extra logic is needed post-listing
/// @dev to be overridden on the child if any extra logic is needed post-listing
function _postExecute() internal virtual {}

function execute() external {
Expand Down
4 changes: 2 additions & 2 deletions src/v3-config-engine/AaveV3Payload.sol
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ abstract contract AaveV3Payload {
CONFIG_ENGINE = engine;
}

/// @dev to be overriden on the child if any extra logic is needed pre-listing
/// @dev to be overridden on the child if any extra logic is needed pre-listing
function _preExecute() internal virtual {}

/// @dev to be overriden on the child if any extra logic is needed post-listing
/// @dev to be overridden on the child if any extra logic is needed post-listing
function _postExecute() internal virtual {}

function execute() external {
Expand Down
2 changes: 1 addition & 1 deletion src/v3-config-engine/IAaveV3ConfigEngine.sol
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ interface IAaveV3ConfigEngine {

/**
* @notice Performs full listings of assets, in the Aave pool configured in this engine instance
* @dev This function allows more customization, especifically enables to set custom implementations
* @dev This function allows more customization, specifically enables to set custom implementations
* for a/v/s tokens.
* IMPORTANT. Use it only if understanding the internals of the Aave v3 protocol
* @param context `PoolContext` struct, effectively meta-data for naming of a/v/s tokens.
Expand Down