feat: add repay method #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakulstra
commented
Sep 21, 2022
| @@ -201,11 +201,23 @@ contract ProtocolV3TestBase is Test { | |||
| IPool pool, | |||
| uint256 amount, | |||
| bool stable | |||
| ) internal { | |||
| ) external { | |||
There was a problem hiding this comment.
made it external as otherwise we cannot try catch it and check specific errors
| console.log('BORROW: %s, Amount %s, Stable: %s', config.symbol, amount, stable); | ||
| pool.borrow(config.underlying, amount, stable ? 1 : 2, 0, address(this)); | ||
| } | ||
|
|
||
| function _repay( |
There was a problem hiding this comment.
wdyt, in most current helpers we require the user to have funds before and provide a flag for approval
I don't see where this is useful as we are not testing the protocol, so having funds and approval could be implicit.
There was a problem hiding this comment.
yup I fully agree with this. having funds and approved should be defaulted on the method.
There was a problem hiding this comment.
Yes, on previous helpers I made, some stuff was clearly useless
sakulstra
commented
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.