-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: compatibility with zkSync #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-CI Comment out tests that still need to be fixed
fix: Assume on tests failing due to low addresses
Use non-reserved addresses for CrossChainReceiverTest
chore: Uncomment some CrossChainReceiverTest test
fix foundry config
fix: correct addresss ranges
uncomment CCIP adapter tests
Uncomment tests due to mock fix
fix: reserved addresses on CrossChainController* tests
fix: use correct test selectors
Uncomment Arb adapter tests
Uncomment `retryEnvelope` Forwarder test
Fix `forwardMessage` mock in `Forwarder.t.sol`
enable CrossChainCommunicationSettingsTest
Ensure called address are not `tx.origin`
Cleanup changes
sendra
approved these changes
May 21, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address several discrepancies found when running the AAVE Delivery Infrastructure tests on the ZkSync network, with the ultimate goal of making AAVE protocol compatible with ZkSync.
The main discrepancies include:
no_zksync_reserved_addresses
that offsets system-generated reserved addresses by 65536, allowing them to fall within the valid address range. This avoids usingprop_filter
and maps invalid addresses to the valid address range, ensuring minimal impact on fuzzer performance.ensure_chunkable
validation, so contract size will be divisible by 32.tx.origin
address fail in ZkVM, so we propose usingvm.assume
to confirm that the address being called is not identical totx.origin
during fuzzing.Test suite specific discrepancies:
Forwarder
test suite needs to be updated to properly mock function calls and return values, ensuring compatibility with ZkVM.By addressing these issues, we aim to facilitate discussions on the changes made and their reasons, ultimately leading to Aave's successful implementation on the ZkSync network.
Contributors
@HermanObst, @Jrigada, @Karrq, @nbaztec
/cc @Deniallugo @dutterbutter