Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump x/tools to v0.1.12 #259

Closed
wants to merge 1 commit into from
Closed

Conversation

ShiChangkuo
Copy link

References: #256
fixes: #255

I've used the same way with @remyleone to upgrade x/tools.

Go version

$ go version
go version go1.19.1 linux/amd64

Command to upgrade

$ go get golang.org/x/[email protected]
go: upgraded golang.org/x/tools v0.0.0-20201028111035-eafbe7b904eb => v0.1.12
 $ go mod tidy
go: downloading golang.org/x/term v0.0.0-20210927222741-03fcf44c2211
$ go mod vendor

@ShiChangkuo
Copy link
Author

@bflad the testing also runs failed in XR007 and XR008

$ go test -v github.com/bflad/tfproviderlint/xpasses/XR007
=== RUN   TestXR007
--- PASS: TestXR007 (0.83s)
=== RUN   TestAnalyzerFixes
    analysistest.go:230: /home/devops01/go/src/github.com/bflad/tfproviderlint/xpasses/XR007/testdata/src/a/alias.go: error formatting resulting source: 9:1: expected expression (and 6 more errors)
        package a

        import (
                e "os/exec"
        )

        var failingAlias =  // want "avoid os/exec.Command"   // I have no idea why the **e.Command** is missing

        func fAlias() {
                 // want "avoid os/exec.Command"

                failingAlias("true")
        }
    analysistest.go:230: /home/devops01/go/src/github.com/bflad/tfproviderlint/xpasses/XR007/testdata/src/a/main.go: error formatting resulting source: 9:1: expected expression (and 3 more errors)
        package a

        import (
                "os/exec"
        )

        var failing =  // want "avoid os/exec.Command"

        func f() {
                // Comment ignored

                //lintignore:XR007
                exec.Command("true")

                exec.Command("true") //lintignore:XR007

                // Failing

                 // want "avoid os/exec.Command"

                failing("true")
        }
--- FAIL: TestAnalyzerFixes (0.65s)
FAIL
FAIL    github.com/bflad/tfproviderlint/xpasses/XR007   1.486s
FAIL

@bflad
Copy link
Owner

bflad commented Apr 13, 2023

After some rigamarole with needing to upgrade Go (#269) and then x/tools (#270), this should be resolved in the upcoming v0.29.0 release 🔜 . Thanks for submitting this and sorry for the delayed resolution.

@bflad bflad closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

internal error: package "context" without types was imported
2 participants