check: support generated cdktf docs #50
Conversation
| DocumentationGlobPattern = `{docs/index.md,docs/{data-sources,guides,resources},website/docs}/**/*` | ||
|
|
||
| LegacyIndexDirectory = `website/docs` | ||
| LegacyDataSourcesDirectory = `website/docs/d` |
There was a problem hiding this comment.
These constants are exported and therefore part of the Go module compatibility promises, however in spot checking various dependents of this Go module, it does not appear that any drop down to using the Go code directly so it's likely fine that this is being changed.
There was a problem hiding this comment.
Oh I see, I wasn't aware :) Thanks for raising this and thank you for checking if it causes trouble down the road :)
There was a problem hiding this comment.
Other places in this codebase are dependent on these values exactly matching their original values, so need to follow this up with additional changes.
Co-authored-by: Brian Flad <[email protected]>
There was a problem hiding this comment.
These changes look good, but there's a new test failure:
--- FAIL: TestCheck (0.00s)
--- FAIL: TestCheck/valid_legacy_directories_requiring_side_navigation (0.00s)
check_test.go:184: expected error, got no error
The ERB side navigation check is very outdated and unnecessary to maintain in this linter at this point so as a followup to this I'll remove all that functionality.
Thanks so much, @DanielMSchmidt 🚀
No description provided.