MGDSTRM-10094 making KafkaCluster.fromKafka not modify the ManagedKafka #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
operator
MikeEdgar
approved these changes
Feb 27, 2023
shawkins
force-pushed
the
MGDSTRM-10094
branch
from
7521bd3 to
098dbea
Compare
|
SonarCloud Quality Gate failed. |
|
@ppatierno if there are no objections, I'll go ahead and merge this. |
|
No objections ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the upgrade annotations from the managedkafka to kafka. After this version is rolled out, we'll be able to remove the logic in the controller that is checking for moving the annotations and remove the annotations from the list of ones that are managed by the operator.