Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump peter-evans/repository-dispatch from 1 to 2 #1586

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 21, 2023

Bumps peter-evans/repository-dispatch from 1 to 2.

Release notes

Sourced from peter-evans/repository-dispatch's releases.

Repository Dispatch v2.0.0

What's New

  • Updated runtime to Node.js 16
    • The action now requires a minimum version of v2.285.0 for the Actions Runner.
    • If using GitHub Enterprise Server, the action requires GHES 3.4 or later.

What's Changed

Full Changelog: peter-evans/repository-dispatch@v1.1.3...v2.0.0

Repository Dispatch v1.1.3

  • Improved error message for 404 errors. These errors can also be a result of insufficient token permissions.

Repository Dispatch v1.1.2

  • Dependency updates

Repository Dispatch v1.1.1

  • Dependency updates

Repository Dispatch v1.1.0

  • Converted action to Typescript
  • Minor improvements

Repository Dispatch v1.0.1

  • Dependency updates
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [peter-evans/repository-dispatch](https://github.com/peter-evans/repository-dispatch) from 1 to 2.
- [Release notes](https://github.com/peter-evans/repository-dispatch/releases)
- [Commits](peter-evans/repository-dispatch@v1...v2)

---
updated-dependencies:
- dependency-name: peter-evans/repository-dispatch
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner February 21, 2023 09:47
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #1586 (54b76a2) into main (028bfce) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1586   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files         158      158           
  Lines       14759    14759           
=======================================
  Hits        12071    12071           
  Misses       2264     2264           
  Partials      424      424           
Flag Coverage Δ
unittests 81.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@dimakis dimakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend pinning the SHA of any external actions.

@machi1990
Copy link
Contributor

I'd recommend pinning the SHA of any external actions.

+1, this can be addressed separately. Do you @dimakis or @jackdelahunt see any issue with this update? It's the one used to notify the SDK repo of the changes.

@miguelsorianod
Copy link
Contributor

I'd recommend pinning the SHA of any external actions.

What is the reason for it? I am trying to understand the issue. Dependabot will notify about new changes on them but not automatically upgrade them unless we approve it

@jackdelahunt
Copy link
Contributor

jackdelahunt commented Feb 23, 2023

What is the reason for it? I am trying to understand the issue. Dependabot will notify about new changes on them but not automatically upgrade them unless we approve it

I think this is mentioning the same issues as this PR noted. Even though the version may stay the same things can change.

@miguelsorianod
Copy link
Contributor

miguelsorianod commented Feb 23, 2023

What is the reason for it? I am trying to understand the issue. Dependabot will notify about new changes on them but not automatically upgrade them unless we approve it

I think this is mentioning the same issues as this PR noted. Even though the version may stay the same things can change.

What would be the criteria then to decide if an action is trusted or not?
As a side note, if we decide that an action is not trusted then we would pin to the SHA. Which means we would never use the automated updates provided by dependabot.

@dimakis
Copy link
Contributor

dimakis commented Feb 23, 2023

What is the reason for it? I am trying to understand the issue. Dependabot will notify about new changes on them but not automatically upgrade them unless we approve it

I think this is mentioning the same issues as this PR noted. Even though the version may stay the same things can change.

What would be the criteria then to decide if an action is trusted or not? As a side note, if we decide that an action is not trusted then we would pin to the SHA. Which means we would never use the automated updates provided by dependabot.

In the RedHat-developer org we are moving towards trusting GH actions and companies like Docker etc. whilst any solo contributor's action would be a pinned SHA, it comes on advice from the prod sec team

@dimakis
Copy link
Contributor

dimakis commented Feb 23, 2023

I'd recommend pinning the SHA of any external actions.

+1, this can be addressed separately. Do you @dimakis or @jackdelahunt see any issue with this update? It's the one used to notify the SDK repo of the changes.

I don't see any issue, but to be honest I don't know a whole lot about this 🤦

@machi1990
Copy link
Contributor

I don't see any issue, but to be honest I don't know a whole lot about this facepalm

Thanks @dimakis From looking at the changelog, it should be safe to merge.

@machi1990 machi1990 merged commit 7d8817c into main Feb 28, 2023
@machi1990 machi1990 deleted the dependabot/github_actions/peter-evans/repository-dispatch-2 branch February 28, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code github
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants