Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MGDSTRM-9301] Generate certificates in Java and upgrade IT Keycloak #239

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

MikeEdgar
Copy link
Contributor

Also add Makefile for easier dev startup, remove old env and IDE configurations from pre-Quarkus migration.

Signed-off-by: Michael Edgar [email protected]

@MikeEdgar MikeEdgar force-pushed the MGDSTRM-9301 branch 2 times, most recently from b4bb416 to dbc4b75 Compare February 10, 2023 15:39
@MikeEdgar MikeEdgar requested a review from biswassri February 10, 2023 16:53
@MikeEdgar MikeEdgar added this to the 0.14.0 milestone Feb 13, 2023
Copy link
Contributor

@biswassri biswassri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, how can I test this?

@MikeEdgar
Copy link
Contributor Author

Just one question, how can I test this?

The GitHub CI tests the system tests themselves and you can try the new make dev and make dev-tls commands in dev mode. They will leverage docker-compose and dev-tls will generate and deploy Kafka with TLS enabled.

@biswassri
Copy link
Contributor

Thanks Mike!

Also add Makefile for easier dev startup, remove old env and IDE
configurations from pre-Quarkus migration.

Signed-off-by: Michael Edgar <[email protected]>
@biswassri
Copy link
Contributor

biswassri commented Feb 27, 2023

@MikeEdgar Lgtm, the changes work fine for me Thanks!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MikeEdgar MikeEdgar merged commit bbe14be into bf2fc6cc711aee1a0c2a:main Feb 28, 2023
@MikeEdgar MikeEdgar deleted the MGDSTRM-9301 branch February 28, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants