[MGDSTRM-9160] Process authentication and admin client construction as blocking #213
Conversation
MikeEdgar
changed the title
MikeEdgar
force-pushed
the
MGDSTRM-9160
branch
7 times, most recently
from
f9ad0d8 to
40fd775
Compare
MikeEdgar
changed the title
| @@ -37,6 +37,7 @@ | |||
| import java.util.stream.Collectors; | |||
|
|
|||
| @Path("/api/v1") | |||
| @Blocking | |||
There was a problem hiding this comment.
@MikeEdgar is there a performance impact here that we should test for?
There was a problem hiding this comment.
I'm looking into this.
There was a problem hiding this comment.
I ended up backing out this change and adjusting the createAdminClient method to return a CompletableFuture where the Kafka client creation occurs in on worker thread. Also the time allowed for processes running on an event loop thread was increased from the default of 2000ms to 4000ms. This seems reasonable for situations where the server is running with constrained CPU.
I was also successful in getting this to run with a native executable (a few other small changes) with very good performance.
MikeEdgar
force-pushed
the
MGDSTRM-9160
branch
2 times, most recently
from
abfe654 to
a8f5457
Compare
Avoids running blocking operations (JWKS retrieval and Kafka Client setup) on the Vert.x event loop/IO threads.
Minor adjustments to allow native executable: - Add `@RegisterForReflection` to `OperationsHandler` - Provide default to `kafka.admin.oauth.enabled`
|
Kudos, SonarCloud Quality Gate passed! |
MikeEdgar
changed the title
Avoids complexity of running various subtasks of some operations on a worker thread.