Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGDSTRM-9180-Unmapped URLs result in unhandled HTTP status 500 #212

Merged
merged 5 commits into from
Jul 25, 2022

Conversation

biswassri
Copy link
Contributor

@biswassri biswassri commented Jul 15, 2022

This is to fix admin server error handling for NotFoundException to a new generic error code that returns a 404 status.

@biswassri biswassri requested review from MikeEdgar and rareddy July 22, 2022 17:20
Copy link
Contributor

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One bug to fix and a suggestion to enhance the test.

@MikeEdgar MikeEdgar added this to the 0.12.0 milestone Jul 22, 2022
Copy link
Contributor

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @biswassri

Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@biswassri biswassri merged commit 80d6749 into bf2fc6cc711aee1a0c2a:main Jul 25, 2022
@biswassri biswassri deleted the exception branch August 31, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants