-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGDSTRM-9180-Unmapped URLs result in unhandled HTTP status 500 #212
Conversation
…hrown NotFoundException
kafka-admin/src/main/java/org/bf2/admin/kafka/admin/handlers/CommonHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One bug to fix and a suggestion to enhance the test.
kafka-admin/src/main/java/org/bf2/admin/kafka/admin/handlers/CommonHandler.java
Outdated
Show resolved
Hide resolved
systemtests/src/test/java/org/bf2/admin/kafka/systemtest/plain/RestEndpointTestIT.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @biswassri
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This is to fix admin server error handling for
NotFoundException
to a new generic error code that returns a404
status.