-
-
Notifications
You must be signed in to change notification settings - Fork 1
Idea: update rfc format #110
Comments
Rust's RFC looks good to me, let's resolve this problem together with #99 |
Some detailed ideas:
|
For |
Since the RFC number is PR number, i think this is not necessary, but may help jump quickly to the page. I think |
|
For complex GSPs, we usually create an issue to track like: beyondstorage/go-storage#560 I think it's a good idea to create an issue to track the implementations. |
For now, our idea/proposal issue is separated from the implementation status tracking ones. Is it a good idea to merge them into one? |
I prefer to merge together. |
I think before a proposal, there may or may not be some problem issues we want to solve. So there are:
Idea issue is optional and can be closed when a proposal PR is opened (or closed by the proposal PR?). Tracking issue is required, linked in the proposal, and can close problem issues. |
Since they are in different repos, they can't be merged. Or do you think putting tracking issue in |
LGTM. It makes sense to have an issue to track the whole process from an idea to the proposal and finally, the implementations. |
I think one possible reason for separating the tracking issue is that we may already have some discussion in the idea issue and proposal PR, so a separate one may be cleaner? Anyway, I'm OK with either style. |
I have a problem: If we separate the tracking issue from the idea issue, what's the timing to create the tracking issue?
Rust's RFC uses the second way: rust-lang/rfcs@644025d , see also rust-lang/rfcs#2603 (comment) The maintainer will update the proposal's link just before merged, and the author just needs to keep them empty. |
@Xuanwo What is a committer? Do we have this notion? |
Well, we have not defined We will track this problem in #116 |
The current proposal process and format is specified by https://github.com/beyondstorage/specs/blob/master/rfcs/17-proposal-process.md and https://github.com/beyondstorage/specs/blob/master/spec/2-proposal.md.
The metadata
status
andupdated_at
are required.For
status
, the transitiondraft
->candidate
->finished
is troublesome (have to start a PR to update status). In practice, this is not followed (There are 18 rfcs with statusdraft
. Actually, we implemented a proposal immediately after an RFC.As an alternative, we can link an issue to track the implementation status.
For
updated_at
, we often forgot to update this when a proposal was discussed for days. And I think maybe the date information is not important (or only givecreated_at
?ref: Rust RFC https://github.com/rust-lang/rfcs
metadata
The text was updated successfully, but these errors were encountered: