fix: macUpdater - change copyFileSync to async operation to unblock…

… the main thread (electron-userland#8623) Fix electron-userland#8622 Co-authored-by: Damon Yu <[email protected]>
beyondkmp · Oct 23, 2024 · cfa67c0 · cfa67c0
1 parent 74d98d8
commit cfa67c0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/khaki-schools-provide.md b/.changeset/khaki-schools-provide.md
@@ -0,0 +1,5 @@
+---
+"electron-updater": patch
+---
+
+fix: copyFileSync operation will block the main thread
diff --git a/packages/electron-updater/src/MacUpdater.ts b/packages/electron-updater/src/MacUpdater.ts
@@ -1,6 +1,6 @@
 import { AllPublishOptions, newError, safeStringifyJson } from "builder-util-runtime"
-import { pathExistsSync, stat } from "fs-extra"
-import { createReadStream, copyFileSync } from "fs"
+import { pathExistsSync, stat, copyFile } from "fs-extra"
+import { createReadStream } from "fs"
 import * as path from "path"
 import { createServer, IncomingMessage, Server, ServerResponse } from "http"
 import { AppAdapter } from "./AppAdapter"
@@ -117,11 +117,11 @@ export class MacUpdater extends AppUpdater {
           await this.httpExecutor.download(zipFileInfo.url, destinationFile, downloadOptions)
         }
       },
-      done: event => {
+      done: async event => {
         if (!downloadUpdateOptions.disableDifferentialDownload) {
           try {
             const cachedUpdateFilePath = path.join(this.downloadedUpdateHelper!.cacheDir, CURRENT_MAC_APP_ZIP_FILE_NAME)
-            copyFileSync(event.downloadedFile, cachedUpdateFilePath)
+            await copyFile(event.downloadedFile, cachedUpdateFilePath)
           } catch (error: any) {
             this._logger.warn(`Unable to copy file for caching for future differential downloads: ${error.message}`)
           }