feat(datatrak): RN-1467: survey submission sync indicator #6049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaskfla
changed the title
<RecentSurveysSection> readability
jaskfla
commented
Jan 14, 2025
packages/datatrak-web/src/views/LandingPage/SurveyResponsesSection.tsx
Outdated
Show resolved
Hide resolved
…icator # Conflicts: # packages/datatrak-web/src/views/LandingPage/RecentSurveysSection.tsx
|
Marking as draft so I don’t accidentally merge this PR. There are a couple PRs stacked on this one |
* shorter varname * simplify CSS, logical properties * list semantics * derive type * true ellipsis * use `useIsMobile` * remove unmatched brace * logical properties * simplify column template * simplify grid rows and templates * add missing import * logical properties * fix section alignment * organise imports * simplify desktop–mobile logic * reset `ul, ul` margin * export `<DateTimeDisplay>` * full wifth `<SectionHeading>` * speed up render --------- Co-authored-by: Andrew <[email protected]>
* shorter varname * simplify CSS, logical properties * list semantics * derive type * true ellipsis * use `useIsMobile` * remove unmatched brace * logical properties * simplify column template * simplify grid rows and templates * add missing import * logical properties * fix section alignment * organise imports * simplify desktop–mobile logic * clean up Tile implementation * reset `ul, ul` margin * export `<DateTimeDisplay>` * full wifth `<SectionHeading>` * fix key * organise imports * cleaner error state remove unused var * better varname * adjust task skeleton * adjust breakpoint * fix mobile margins * simplify `<NoTasksSection>` * more sensible layout * speed up render * faster render * balance text * fix build * shallower * remove dead var * avoid nested `?:` * organise imports --------- Co-authored-by: Andrew <[email protected]>
jaskfla
changed the title
<RecentSurveysSection> readability* shorter varname * simplify CSS, logical properties * list semantics * derive type * true ellipsis * use `useIsMobile` * remove unmatched brace * logical properties * simplify column template * simplify grid rows and templates * add missing import * logical properties * fix section alignment * organise imports * simplify desktop–mobile logic * clean up Tile implementation * reset `ul, ul` margin * export `<DateTimeDisplay>` * full wifth `<SectionHeading>` * fix key * organise imports * cleaner error state remove unused var * better varname * adjust task skeleton * adjust breakpoint * fix mobile margins * simplify `<NoTasksSection>` * more sensible layout * speed up render * faster render * balance text * cherry pick `isWebApp` from #6041 * sync indicator * comment oops * use `titleAccess` prop name, mirroring MUI * fix alignment * more sensible organisation * fix build * shallower * remove dead var * fix type * simplify * better varname * tweak alignment --------- Co-authored-by: Andrew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue RN-1467: Survey Submission Sync UI
Changes:
Screenshots: