Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datatrakWeb): RN-1405: Fix file uploads from web not being saved correctly #5822

Merged
merged 14 commits into from
Dec 16, 2024
Merged

fix(datatrakWeb): RN-1405: Fix file uploads from web not being saved correctly #5822

merged 14 commits into from
Dec 16, 2024

Conversation

alexd-bes
Copy link
Contributor

@alexd-bes alexd-bes commented Aug 1, 2024 •
edited
Loading

Issue RN-1405: Fix file uploads not working from web

Changes:

  • When the file being uploaded is a base64 encoded file (as happens from DataTrak Web) then convert to a Buffer and save with the correct file type

Post release steps:

  • Identify any broken uploads and ask the relevant person who completed that survey response if they can resubmit the response with the new file OR get a dev to manually load to s3 and update the answer values in the DB

tcaiger
tcaiger reviewed Aug 1, 2024
View reviewed changes
packages/meditrak-app/app/version/isBeta.jsx Outdated
@@ -7,4 +7,5 @@ import Config from 'react-native-config';

export const isBeta = !!Config.BETA_BRANCH;
export const betaBranch = Config.BETA_BRANCH;
export const centralApiUrl = Config.CENTRAL_API_URL;
export const centralApiUrl = 'http://10.0.2.2:8090/v2';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this is just test code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah I thought I had unticked that one, will remove!

tcaiger
tcaiger approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@tcaiger tcaiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the question about the isBeta file but otherwise looks good

avaek and others added 6 commits October 17, 2024 07:13
@tcaiger tcaiger merged commit 9cbb126 into dev Dec 16, 2024
44 checks passed
@tcaiger tcaiger deleted the rn-1405-handle-file-uploads-from-web branch December 16, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcaiger tcaiger tcaiger approved these changes

Assignees

@tcaiger tcaiger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexd-bes @tcaiger @avaek