Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: unify Bash code style #5568

Open
wants to merge 27 commits into
base: dev
Choose a base branch
from
+479 −312
Open

style: unify Bash code style #5568

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
80a8957
delete unused variable
jaskfla Apr 6, 2024
0a80dbe
portable shebang for Bash scripts
jaskfla Apr 6, 2024
bd6f024
prefer `.` to `source`
jaskfla Apr 6, 2024
fa29c90
prefer `echo` without `""` for blank lines
jaskfla Apr 6, 2024
3807364
`download-env-vars`: log in to Bitwarden first
jaskfla Apr 6, 2024
92433da
simplify loop over `*.env.example` files
jaskfla Apr 6, 2024
d34a646
convenience variables for ANSI codes/sequences
jaskfla Apr 6, 2024
64b9ac7
inline `then` in `if` header
jaskfla Apr 6, 2024
2213a9a
update env var message to refer to Bitwarden
jaskfla Apr 6, 2024
8702ea2
prettify `download-env-vars` output
jaskfla Apr 6, 2024
73e1797
prettify `backendStartDev.sh` output
jaskfla Apr 6, 2024
a1db38f
prettify `dumpDatabase.sh` output
jaskfla Apr 6, 2024
77b76b2
prefer ``[[`` over `[`, and `=` over `==` in Bash
jaskfla Apr 6, 2024
1d10de0
prefer `$(…)` over backtick command substitution
jaskfla Apr 7, 2024
0be5e6f
prettify `patchMvRefereshModule.sh` output
jaskfla Apr 7, 2024
15b43de
prefer single quotes when no variables
jaskfla Apr 7, 2024
507fa83
prefer ``(( ))`` over `[[ ]]` for arithmetic
jaskfla Apr 7, 2024
1160b28
prefer array over string in `buildNonInternalDeps`
jaskfla Apr 7, 2024
0ba73f1
prefer array for `getDeployablePackages.sh`
jaskfla Apr 8, 2024
ca00437
refactor: clearer way to get current branch
jaskfla Apr 8, 2024
97c51d6
double-quote variables, avoiding `${…}`
jaskfla Apr 8, 2024
090d23c
prefer array in `mergeEnvForDB.sh`
jaskfla Apr 8, 2024
8da68e4
exit on error
jaskfla Apr 9, 2024
cca8b59
Merge branch 'dev' into shellharden
jaskfla Jun 19, 2024
65907a7
Merge branch 'dev' into shellharden
jaskfla Jun 19, 2024
65bc43b
Merge branch 'dev' into shellharden
jaskfla Jul 8, 2024
8cd0e8f
Merge branch 'dev' into shellharden
jaskfla Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/data-api/scripts/installMvRefreshModule.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#!/bin/bash
DIR=$(dirname "$0")


DIR=$(pwd "$0")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Immediately overwritten in line 4

Expand Down
1 change: 0 additions & 1 deletion scripts/bash/getInternalDependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ for dependency in ${internal_dependencies[@]}; do
done

# remove any duplicates
deduplicated_union=()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never used and not exported

for i in "${!internal_dependencies[@]}"; do
for j in "${!internal_dependencies[@]}"; do
if [[ i -ne j ]] && [[ ${internal_dependencies[i]} = ${internal_dependencies[j]} ]]; then
Expand Down