New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove data source refs in metadata pullers #5367

Open

kael89 wants to merge 3 commits into dev from remove-data-source-refs-in-metadata-pullers

Collaborator

kael89 commented Jan 22, 2024

Just clearning the ground before I split the internal implementation of metadata pulers data broker.

Remove unused translator dependencies
Added missing tests for DHIS metadata pullers. Ran them locally against existing logic, they pass
Renamed dataSource references to dataElement or dataGroup as appropriate. Ran the tests again, they pass

Old data-broker coverage: 85.99%
New data-broker coverage: 88.62% ⬆️

kael89 requested review from edmofro and rohan-bes

January 22, 2024 20:47

kael89 added 3 commits

January 23, 2024 08:58


          [no-issue]: Remove unused translator dependency

d68bd27


          [no-issue]: Add tests for metadata pullers

a3ee555


          [no-issue]: Remove data source references in DHIS pullers

d6e36af

kael89 force-pushed the remove-data-source-refs-in-metadata-pullers branch from 19c81e7 to d6e36af Compare

January 22, 2024 22:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet