RN-973 Upgrade Meditrak #5120

IgorNadj · 2023-10-29T23:10:16Z

Issue #: RN-973

Package updates:

Start from a brand new react-native. Add up to date packages and get it building. Both Android and iOS.

DEPRECATED PACKAGES LIST

react-native-camera
- react-native-vision-camera
- must upgrade, old version causing all sorts of issues
- ✅ Upgraded
react-native-qrcode-scanner
- The recommendation of most developers that were previously using this library is to consider using react-native-vision-camera with its plugin vision-camera-code-scanner
- ✅ Upgraded
react-native-side-menu
- Recommendation is react-native-side-menu-updated
- 🟡 Not upgraded, works fine as is, will leave for a future PR
react-navigation
- Recommendation is @react-navigation/native
- 🟡 Not upgraded, works fine as is, will leave for a future PR
- Take react-navigation-redux-helpers with it?
  - Yes, not needed, only used to persist state, can be done with core lib: https://reactnavigation.org/docs/state-persistence/
sha256
- 🟡 Not upgraded, works fine as is, will leave for a future PR

AppCenter changes:

Fixed the builds for Android and iOS.
iOS has been re-setup to build and release through AppCenter following AppCenter documentation.

Manual release tasks

Update Slab for Meditrak app releasing

Tried v20 but node 18 has breaking changes which break react-native-dotenv, see goatandsheep/react-native-dotenv#468

This was needed because trying to install newer versions of tools e.g. node-gpy was not working while older versions were already installed + each runs on different versions of node.

react-native-dotenv wasnt working with node 16

…ng specific yargs version at top level

Fixes issue with incompatible versions clashing, see babel/babel#15765 (comment)

rohan-bes

Thanks for this @IgorNadj!

Ran through a local install and had a minor issue with realm but aside from that all working well. Wanna go through this together on Friday and then hopefully we can merge 👍

rohan-bes · 2023-11-22T05:14:20Z

packages/meditrak-app/README.md


-Android and iOS app for surveying medical facilities
+- nvm use


I had to add an .nvmrc file with 16.20.2 in it to the root of the meditrak-app package

rohan-bes · 2023-11-22T05:18:44Z

packages/meditrak-app/package.json

-    "redux-persist": "^5.9.1",
+    "react-navigation-stack": "^2.10.4",
+    "react-redux": "^8.1.2",
+    "realm": "^12.1.0",


When testing this locally I was having issues with a missing realm-constants.json file in node_modules/ream. There seems be something that some other users have encountered: realm/realm-js#6270

Apparently there's meant to be a post-install script that creates that file but something seemed to be going wrong for me.

Bumping to 12.3.0 fixed the issue though, currently yarn.lock has resolved to 12.2.1

Try to upgrade to v12.3.1 as we have a fix for it 😄

Thanks @kneth 🙏

rohan-bes

Awesome stuff, thanks for all the work!

IgorNadj · 2023-11-24T03:33:30Z

Merging before test pass because this only affects MediTrak App, which is on a change freeze pending this upgrade.

I have done a smoke test on the build and run of web-frontend and it passed, any other issues will be caught by release regression testing.

IgorNadj changed the title ~~RN-973 Upgrade Meditrak~~ RN-973 Upgrade Meditrak (Builds locally) Oct 30, 2023

IgorNadj marked this pull request as draft October 30, 2023 00:06

IgorNadj changed the base branch from dev to upgrade-meditrak-epic October 30, 2023 00:08

IgorNadj force-pushed the rn-973-upgrade-meditrak20 branch from ca47f0d to bfb78bd Compare October 30, 2023 01:00

IgorNadj marked this pull request as ready for review October 30, 2023 01:11

IgorNadj force-pushed the rn-973-upgrade-meditrak20 branch 5 times, most recently from 4e6db0c to b477624 Compare November 3, 2023 05:33

IgorNadj changed the title ~~RN-973 Upgrade Meditrak (Builds locally)~~ RN-973 Upgrade Meditrak Nov 6, 2023

IgorNadj changed the base branch from upgrade-meditrak-epic to dev November 6, 2023 05:10

IgorNadj added 18 commits November 6, 2023 16:12

Prerequisite: node v16+ (selected v16.20.2)

531f3a2

Tried v20 but node 18 has breaking changes which break react-native-dotenv, see goatandsheep/react-native-dotenv#468

npx react-native@latest init TupaiaMediTrak

4f412f9

Rename new package, add to workspace, nohoist it

8088455

Add info for devs in README

bc2ac69

cp -r meditrak-app/app meditrak-app-new/app

6793a4e

find . -name '*.js' -exec sh -c 'mv -zsh -zsh.jsx' {} \;

29b52c5

Copy project root files from meditrak-app to meditrak-app-new

db33243

Rm meditrak-app/package.json.

7f21534

This was needed because trying to install newer versions of tools e.g. node-gpy was not working while older versions were already installed + each runs on different versions of node.

Copy package.json deps from meditrak-app to meditrak-app-new

ba86e1d

Rm deprecated packages

b3270b2

Fix nanoid import after upgrade

6d033ff

Temporarily stub out appcenter and bugsnag

b9c33d5

Rm unused package-lock.json

ac69cb4

Add missing package @babel/plugin-proposal-export-default-from

a3e932a

Swap react-native-dotenv out for react-native-config

2a40a65

react-native-dotenv wasnt working with node 16

Fix module resolution

5dc9d05

Upgrade Realm model definitions for new version

978b316

Add missing peer deps

cdb229b

IgorNadj force-pushed the rn-973-upgrade-meditrak20 branch from 74d6a56 to 60a9af1 Compare November 6, 2023 05:12

IgorNadj added 3 commits November 6, 2023 16:34

Add missing dep

0ba6178

Bump Meditrak version

ddcba32

Fix build issue by removing global package:build:react-scripts, setti…

7547dec

…ng specific yargs version at top level

IgorNadj force-pushed the rn-973-upgrade-meditrak20 branch 2 times, most recently from c3940e4 to 5d9ecee Compare November 9, 2023 05:47

Add dep directly to fix babel error

a1025d2

IgorNadj force-pushed the rn-973-upgrade-meditrak20 branch from 5d9ecee to a1025d2 Compare November 9, 2023 06:05

Add dep directly to fix build issue

3d677e6

IgorNadj force-pushed the rn-973-upgrade-meditrak20 branch from 560ba48 to 3d677e6 Compare November 9, 2023 23:16

IgorNadj added 10 commits November 10, 2023 10:32

Add missing dep

a368647

Add missing deps

4be31ff

Add missing deps for ui-map-components

842abe5

Lock down @babel/types version

aafbd9e

Fixes issue with incompatible versions clashing, see babel/babel#15765 (comment)

Reimplement Bugsnag

a259a57

Reimplement Appcenter analytics

7a5a85a

Bump version

e2ed5e9

Fix bugsnag config, pod install

f66699f

Remove RN launch screen text

5dceafa

Bump version

7e15a5e

rohan-bes reviewed Nov 22, 2023

View reviewed changes

IgorNadj added 3 commits November 24, 2023 12:37

Add missing nvmrc

85c3518

Bump realm to fix install issue

0ebd897

Rm obsolete resolutions override

4e48f0e

rohan-bes approved these changes Nov 24, 2023

View reviewed changes

Bump version

664efee

IgorNadj merged commit c949df4 into dev Nov 24, 2023
42 checks passed

IgorNadj deleted the rn-973-upgrade-meditrak20 branch November 24, 2023 03:33

IgorNadj restored the rn-973-upgrade-meditrak20 branch November 30, 2023 05:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RN-973 Upgrade Meditrak #5120

RN-973 Upgrade Meditrak #5120

IgorNadj commented Oct 29, 2023 •

edited

Loading

rohan-bes left a comment

rohan-bes Nov 22, 2023

rohan-bes Nov 22, 2023

kneth Nov 23, 2023

rohan-bes Nov 24, 2023

rohan-bes left a comment

IgorNadj commented Nov 24, 2023


		Android and iOS app for surveying medical facilities
		- nvm use

RN-973 Upgrade Meditrak #5120

RN-973 Upgrade Meditrak #5120

Conversation

IgorNadj commented Oct 29, 2023 • edited Loading

Issue #: RN-973

Package updates:

AppCenter changes:

Manual release tasks

rohan-bes left a comment

Choose a reason for hiding this comment

rohan-bes Nov 22, 2023

Choose a reason for hiding this comment

rohan-bes Nov 22, 2023

Choose a reason for hiding this comment

kneth Nov 23, 2023

Choose a reason for hiding this comment

rohan-bes Nov 24, 2023

Choose a reason for hiding this comment

rohan-bes left a comment

Choose a reason for hiding this comment

IgorNadj commented Nov 24, 2023

IgorNadj commented Oct 29, 2023 •

edited

Loading