add Spring.SetAllyTeamStartBox synced control
#958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprunk
reviewed
Aug 19, 2023
nbusseneau
force-pushed
the
pr/add-setallyteamstartbox
branch
from
8f9449d to
d809bf5
Compare
sprunk
reviewed
Aug 22, 2023
sprunk
reviewed
Aug 22, 2023
sprunk
reviewed
Aug 22, 2023
sprunk
reviewed
Aug 22, 2023
sprunk
reviewed
Aug 22, 2023
sprunk
reviewed
Aug 22, 2023
`AllyTeam` data is first loaded in `CGameSetup` from the start script, and is later passed down to `TeamHandler` from `CGameSetup`. Since `TeamHandler` is responsible for storing dynamic information during the game, whereas `CGameSetup` only stores the initial data as loaded from the start script, we remove all calls to `CGameSetup::GetAllyStartingData` in favor of information coming from `TeamHandler` to ensure that we consistently retrieve up-to-date data.
This new control allows to change an ally team's start box from a synchronized context, thereby opening up the possibility for Lua gadgets to reposition start boxes as needed.
nbusseneau
force-pushed
the
pr/add-setallyteamstartbox
branch
from
d809bf5 to
af67703
Compare
sprunk
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new control allows to change an ally team's start box from a synchronized context, thereby opening up the possibility for Lua gadgets to reposition start boxes as needed.
Note
This PR depends on #954 to be merged first: #954 fixes a behaviour discovered while adding this new control, where after repositioning boxes via
Spring.SetAllyTeamStartBoxsome things were working as intended (e.g. display of the startbox is correctly relocated) and some others were not (e.g. clamping of teams start position inside of the ally team startbox), because of the factAllyTeamdata is coming from multiple source.