feat(OverviewCam): Add OverviewRotation option #714
Conversation
Add "OverviewRotation" option, default false, so Overview camera controller is oriented in the closest direction to last camera controller rotation. This avoids jarring transitions, especially useful for flipped overhead camera.
| @@ -9,9 +9,18 @@ class COverviewController : public CCameraController | |||
| { | |||
| public: | |||
| COverviewController(); | |||
| ~COverviewController(); | |||
|
|
|||
| constexpr static float3 DIR_UP = float3(0.0f, -0.999999500000375f, -0.000999999500000375f); // -90 deg | |||
There was a problem hiding this comment.
looks suspiciously close to (0, -1, 0), could use a comment on why the tiny difference
There was a problem hiding this comment.
That's a good question! This is the explicit version of what was the previous dir float3(0.0f, -1.0f, -0.001f).ANormalize().
I have absolutely no idea! My intuition was that it is looking down (almost negative 1 on y direction) and a tiny x,-x,z,-z component for each of the directions (the comments are wrong).
There was a problem hiding this comment.
Try (0, -1, 0) and see what happens.
I think it's just to specify a "heading" around the Y axis, i.e. otherwise it's unspecified where "north" is, for example for camera panning purposes - these two could both have (0, -1, 0) dir up:
But hopefully that's where the other constants (DIR_{LEFT,RIGHT}) come in to disambiguate.
A straight top-down angle also used to break shadows in the past AFAIK, could check if that is still the case.
lhog
force-pushed
the
BAR105
branch
2 times, most recently
from
3925acd to
d32df95
Compare
|
What is the status here? |
lhog
force-pushed
the
BAR105
branch
2 times, most recently
from
41c6b2b to
1c21706
Compare
|
Don't know. Probably not needed |
Add "OverviewRotation" option, default false, so Overview camera controller is oriented in the closest direction to last camera controller rotation.
This avoids jarring transitions, especially useful for flipped overhead camera.