Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring.AllocateTable -> table.new #1803

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Spring.AllocateTable -> table.new #1803

merged 1 commit into from
Dec 7, 2024

Conversation

sprunk
Copy link
Collaborator

@sprunk sprunk commented Dec 7, 2024

Some Lua extensions (notably, LuaJIT) seem to offer this feature as table.new, with the same args we do, and it does feel like a more natural place for it to be. Fixes #1700.

Some Lua extensions (notably, LuaJIT) seem to offer this feature as `table.new`,
with the same args we do, and it does feel like a more natural place for it to be.
@saurtron
Copy link
Collaborator

saurtron commented Dec 7, 2024

tested and seems to work fine

@lhog
Copy link
Collaborator

lhog commented Dec 7, 2024

Good idea!

@lhog lhog merged commit 1f11c97 into master Dec 7, 2024
2 checks passed
@sprunk sprunk deleted the table-new branch January 6, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perhaps Spring.AllocateTable should be table.new
4 participants