Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tdfID weapon def #1467

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Remove tdfID weapon def #1467

merged 2 commits into from
Nov 3, 2024

Conversation

sprunk
Copy link
Collaborator

@sprunk sprunk commented Apr 24, 2024

Replaced with regular ID in COB, removed elsewhere.

Replaced with regular ID in COB, removed elsewhere.
@marcushutchings
Copy link
Collaborator

So how would games track weaponDef ids? If they get hit by weapon id 20, how do they know what weapon that is?

@sprunk
Copy link
Collaborator Author

sprunk commented Apr 24, 2024

They still get the weapon def id. This patch removes tdf id.

@sprunk
Copy link
Collaborator Author

sprunk commented Apr 25, 2024

No known game sets the tag:
tdfid path:*.lua
tdfid path:*.tdf

@marcushutchings
Copy link
Collaborator

Does anything else need to be removed from the engine if tdf files are not going to be supported?

@sprunk
Copy link
Collaborator Author

sprunk commented Apr 25, 2024

This doesn't affect tdf file support, only the tdfID weapon def, which only has tdf in the name and is otherwise unrelated to tdf files.

@lhog lhog merged commit 8ad8a12 into master Nov 3, 2024
2 checks passed
@lhog lhog deleted the tdf-id branch November 3, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants