Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Boolean rules params #866

Closed
sprunk opened this issue Jun 20, 2023 · 0 comments
Closed

[FR] Boolean rules params #866

sprunk opened this issue Jun 20, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@sprunk
Copy link
Collaborator

sprunk commented Jun 20, 2023 •
edited
Loading

Currently only numbers and strings are accepted. This leads to either weird mixed type params where both implicitly convert to the desired boolean but neither is actually a boolean (1 for true and nil for false) or going with the C convention that goes against regular Lua boolean semantics (1 for true, 0 for false, despite 0 being true in Lua).
sprunk added a commit to sprunk/spring-1 that referenced this issue Jun 24, 2023
@sprunk
Fix beyond-all-reason#866, rules params can now be boolean
bac6e53 
AI and selection filters read them as numbers, 0/1.
@sprunk sprunk added the enhancement New feature or request label Jun 24, 2023
@lhog lhog closed this as completed in dd320bc Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sprunk