[Merged by Bors] - Use default-implemented methods for IntoSystemConfig<>
#7870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-gio
added
A-ECS
alice-i-cecile
approved these changes
Mar 2, 2023
|
Ping @geieredgar for review too if you have time :) |
maniwani
approved these changes
Mar 2, 2023
hymm
added
the
S-Ready-For-Final-Review
james7132
approved these changes
Mar 2, 2023
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
# Objective The trait `IntoSystemConfig<>` requires each implementer to repeat every single member method, even though they can all be implemented by just deferring to `SystemConfig`. ## Solution Add default implementations to most member methods.
bors
bot
changed the title
IntoSystemConfig<>IntoSystemConfig<>
Shfty
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
…7870) # Objective The trait `IntoSystemConfig<>` requires each implementer to repeat every single member method, even though they can all be implemented by just deferring to `SystemConfig`. ## Solution Add default implementations to most member methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The trait
IntoSystemConfig<>requires each implementer to repeat every single member method, even though they can all be implemented by just deferring toSystemConfig.Solution
Add default implementations to most member methods.