Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - bevy_core_pipeline: Fix prepass sort orders #7539

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - bevy_core_pipeline: Fix prepass sort orders #7539

wants to merge 1 commit into from

Conversation

superdump
Copy link
Contributor

Objective

  • Prepass opaque and alpha mask are incorrectly sorted back to front. This slipped through review by accident.

Solution

  • Sort prepass opaque and alpha mask front to back

@superdump superdump requested review from IceSentry and robtfm February 7, 2023 05:52
@superdump superdump added this to the 0.10 milestone Feb 7, 2023
@superdump superdump added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times labels Feb 7, 2023
IceSentry
IceSentry approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some limited testing it doesn't seem to have a significant impact, but the prepass should still match the core_pipeline sorting I think.

@superdump
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 7, 2023
@superdump
bevy_core_pipeline: Fix prepass sort orders (#7539)
6d399bf 
# Objective

- Prepass opaque and alpha mask are incorrectly sorted back to front. This slipped through review by accident.

## Solution

- Sort prepass opaque and alpha mask front to back
@bors
Copy link
Contributor

bors bot commented Feb 7, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title bevy_core_pipeline: Fix prepass sort orders [Merged by Bors] - bevy_core_pipeline: Fix prepass sort orders Feb 7, 2023
@bors bors bot closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robtfm robtfm robtfm approved these changes

@IceSentry IceSentry IceSentry approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Performance A change motivated by improving speed, memory usage or compile times
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@superdump @IceSentry @robtfm