Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - bevy_reflect: Pre-parsed paths #7321

Closed
wants to merge 25 commits into from
Closed

[Merged by Bors] - bevy_reflect: Pre-parsed paths #7321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
47c34fb
Refactor GetPath's parser
james7132 Mar 2, 2022
5da1f0d
Add FieldPath and Access
james7132 Mar 2, 2022
b2d9cf0
Darn clippy
james7132 Mar 2, 2022
b1a52c6
Clean up code and add doc comments
james7132 Mar 4, 2022
e773d8e
Clippy
james7132 Mar 4, 2022
3a61215
Cleanup code a bit more
james7132 Mar 4, 2022
c15bbb5
Handle field number parsing
james7132 Mar 7, 2022
9d7f10c
Update path tests
james7132 Mar 7, 2022
0763808
Add a Display implementation for FieldPath
james7132 Mar 7, 2022
3ad5ace
Add documentation for field index path s
james7132 Mar 7, 2022
0caf893
Clarify doc comment on field index paths.
james7132 Mar 8, 2022
085c965
impl -> dyn
james7132 Mar 8, 2022
20d89bb
Add tests
james7132 Mar 8, 2022
8c1afb4
Update docs.
james7132 May 16, 2022
e8e225b
Update docs.
james7132 May 16, 2022
9a14693
Update docs.
james7132 May 16, 2022
40f81bd
Update docs.
james7132 May 16, 2022
01f87fb
Use associated constants
james7132 May 26, 2022
aa1124d
Add some doc strings
james7132 May 26, 2022
3f00df7
Use the constants more
james7132 May 26, 2022
3b2ae9b
Add more array path tests
MrGVSV Jan 21, 2023
99bc312
Update docs
MrGVSV Jan 21, 2023
bb7aa1f
Rename FieldPath to ParsedPath
MrGVSV Jan 21, 2023
8ac1f0f
Rename GetPath/ParsedPath methods
MrGVSV Jan 21, 2023
93c35a4
Improve docs for ParsedPath::parse
MrGVSV Jan 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions crates/bevy_reflect/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1274,9 +1274,15 @@ bevy_reflect::tests::should_reflect_debug::Test {
fn vec3_path_access() {
let mut v = vec3(1.0, 2.0, 3.0);

assert_eq!(*v.path("x").unwrap().downcast_ref::<f32>().unwrap(), 1.0);
assert_eq!(
*v.reflect_path("x").unwrap().downcast_ref::<f32>().unwrap(),
1.0
);

*v.path_mut("y").unwrap().downcast_mut::<f32>().unwrap() = 6.0;
*v.reflect_path_mut("y")
.unwrap()
.downcast_mut::<f32>()
.unwrap() = 6.0;

assert_eq!(v.y, 6.0);
}
Expand Down
Loading