-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix doc comment "Turbo" -> "Extreme" #7091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
reviewed
Jan 5, 2023
@@ -47,7 +47,7 @@ pub struct Fxaa { | |||
|
|||
/// Use lower sensitivity for a sharper, faster, result. | |||
/// Use higher sensitivity for a slower, smoother, result. | |||
/// Ultra and Turbo settings can result in significant smearing and loss of detail. | |||
/// Ultra and Extreme settings can result in significant smearing and loss of detail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps these should link to their respective settings? That would help prevent such discrepancies in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 👍
joseph-gio
approved these changes
Jan 5, 2023
JMS55
approved these changes
Jan 5, 2023
mockersf
approved these changes
Jan 6, 2023
bors r+ |
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jan 6, 2023
# Objective Doc comment mentions turbo which is a sensitivity that doesn't exist. ## Solution Change the comment to "Extreme" which does exist
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Jan 21, 2023
# Objective Doc comment mentions turbo which is a sensitivity that doesn't exist. ## Solution Change the comment to "Extreme" which does exist
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective Doc comment mentions turbo which is a sensitivity that doesn't exist. ## Solution Change the comment to "Extreme" which does exist
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Doc comment mentions turbo which is a sensitivity that doesn't exist. ## Solution Change the comment to "Extreme" which does exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-Docs
An addition or correction to our documentation
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Doc comment mentions turbo which is a sensitivity that doesn't exist.
Solution
Change the comment to "Extreme" which does exist