Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Make adding children idempotent #6763

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Make adding children idempotent #6763

wants to merge 5 commits into from

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Nov 26, 2022 •
edited
Loading

Objective

Solution

Make push_children idempotent.

@james7132 james7132 added P-Crash A sudden unexpected crash C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Hierarchy Parent-child entity hierarchies labels Nov 26, 2022
@JoJoJet JoJoJet changed the title Warn instead of panicking when parenting is redundant Make adding children idempotent Nov 27, 2022
@JoJoJet JoJoJet requested review from alice-i-cecile and james7132 and removed request for alice-i-cecile November 27, 2022 02:50
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 27, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 28, 2022
@JoJoJet
Make adding children idempotent (#6763)
70d7f80 
# Objective

* Fix #6668
* There is no need to panic when a parenting operation is redundant, as no invalid state is entered.

## Solution

Make `push_children` idempotent.
@bors
Copy link
Contributor

bors bot commented Nov 28, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Make adding children idempotent [Merged by Bors] - Make adding children idempotent Nov 28, 2022
@bors bors bot closed this Nov 28, 2022
@JoJoJet JoJoJet deleted the hierarchy-panic branch November 28, 2022 15:34
taiyoungjang pushed a commit to taiyoungjang/bevy that referenced this pull request Dec 15, 2022
@JoJoJet @taiyoungjang
Make adding children idempotent (bevyengine#6763)
8b6f6ad 
# Objective

* Fix bevyengine#6668
* There is no need to panic when a parenting operation is redundant, as no invalid state is entered.

## Solution

Make `push_children` idempotent.
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@JoJoJet @alradish
Make adding children idempotent (bevyengine#6763)
a3c5f44 
# Objective

* Fix bevyengine#6668
* There is no need to panic when a parenting operation is redundant, as no invalid state is entered.

## Solution

Make `push_children` idempotent.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@JoJoJet @ItsDoot
Make adding children idempotent (bevyengine#6763)
58cb921 
# Objective

* Fix bevyengine#6668
* There is no need to panic when a parenting operation is redundant, as no invalid state is entered.

## Solution

Make `push_children` idempotent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Hierarchy Parent-child entity hierarchies C-Usability A targeted quality-of-life change that makes Bevy easier to use P-Crash A sudden unexpected crash S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic at parent != previous When Adding a Child to a Parent When It's Already a Child
3 participants
@JoJoJet @alice-i-cecile @james7132