-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add AUTO and UNDEFINED const constructors for Size
#5761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weibye
added
A-UI
Graphical user interfaces, styles, layouts, and widgets
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
labels
Aug 21, 2022
TimJentzsch
approved these changes
Aug 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. That are probably common patterns to use.
mockersf
approved these changes
Aug 21, 2022
Weibye
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Aug 21, 2022
afonsolage
approved these changes
Aug 22, 2022
tguichaoua
approved these changes
Aug 22, 2022
bors r+ |
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Add AUTO and UNDEFINED const constructors for
[Merged by Bors] - Add AUTO and UNDEFINED const constructors for Aug 22, 2022
Size
Size
maccesch
pushed a commit
to Synphonyte/bevy
that referenced
this pull request
Sep 28, 2022
# Objective Very small convenience constructors added to `Size`. Does not change current examples too much but I'm working on a rather complex UI use-case where this cuts down on some extra typing :)
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Very small convenience constructors added to `Size`. Does not change current examples too much but I'm working on a rather complex UI use-case where this cuts down on some extra typing :)
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Very small convenience constructors added to `Size`. Does not change current examples too much but I'm working on a rather complex UI use-case where this cuts down on some extra typing :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-UI
Graphical user interfaces, styles, layouts, and widgets
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Very small convenience constructors added to
Size
.Does not change current examples too much but I'm working on a rather complex UI use-case where this cuts down on some extra typing :)