Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Warning message for missing events #5730

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Warning message for missing events #5730

wants to merge 3 commits into from

Conversation

Aceeri
Copy link
Member

@Aceeri Aceeri commented Aug 18, 2022

Objective

  • Reduce debugging burden when using events by telling user when they missed an event.

Solution

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Diagnostics Logging, crash handling, error reporting and performance analysis labels Aug 18, 2022
@Aceeri
Copy link
Member Author

Aceeri commented Aug 18, 2022 •
edited
Loading

Would be nice to have #5731 so we could tell the user which system is the offending reader of events.

Could add it as a #[cfg(debug_assertions)] if we are worried about performance cost of that.

@mockersf
Copy link
Member

Would be nice to have #5731 so we could tell the user which system is the offending reader of events.

Could add it as a #[cfg(debug_assertions)] if we are worried about performance cost of that.

with spans enabled, does the log have the system span?

@Aceeri
Copy link
Member Author

Aceeri commented Aug 19, 2022 •
edited
Loading

@mockersf I'm a bit confused, are we talking about the tracing system spans? Also kind of overplayed the performance aspect the SystemName stuff will just be a clone on a Cow<'static, str> which will basically always be a &'static str.

cart
cart approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure the tracing spans would add the appropriate system context, where relevant. Happy to adjust as needed though with followups. For now, I think this is good to go!

@cart
Copy link
Member

cart commented Aug 30, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 30, 2022
@Aceeri @cart
Warning message for missing events (#5730)
d346274 
# Objective
- Reduce debugging burden when using events by telling user when they missed an event.

## Solution

Co-authored-by: Carter Anderson <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 30, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Warning message for missing events [Merged by Bors] - Warning message for missing events Aug 30, 2022
@bors bors bot closed this Aug 30, 2022
@rmemr rmemr mentioned this pull request Oct 5, 2022
Closed
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@Aceeri @cart @james7132
Warning message for missing events (bevyengine#5730)
5278d12 
# Objective
- Reduce debugging burden when using events by telling user when they missed an event.

## Solution

Co-authored-by: Carter Anderson <[email protected]>
This was referenced Nov 13, 2022
Open
Closed
Closed
@alice-i-cecile alice-i-cecile mentioned this pull request Nov 22, 2022
Closed
bors bot pushed a commit that referenced this pull request Nov 23, 2022
@alice-i-cecile
Remove warning about missed events due to false positives (#6730)
f7fe0e6 
# Objective

- Reverts #5730.
- Fixes #6173, fixes #6596.

## Solution

Remove the warning entirely.

## Changelog

You will no longer be spammed about

> Missed 31 `bevy_input::mouse::MouseMotion` events. Consider
reading from the `EventReader` more often (generally the best
solution) or calling Events::update() less frequently
(normally this is called once per frame). This problem is most
likely due to run criteria/fixed timesteps or consuming events
conditionally. See the Events documentation for
more information.

when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
bors bot pushed a commit that referenced this pull request Nov 23, 2022
@alice-i-cecile
Remove warning about missed events due to false positives (#6730)
3433a7b 
# Objective

- Reverts #5730.
- Fixes #6173, fixes #6596.

## Solution

Remove the warning entirely.

## Changelog

You will no longer be spammed about

> Missed 31 `bevy_input::mouse::MouseMotion` events. Consider
reading from the `EventReader` more often (generally the best
solution) or calling Events::update() less frequently
(normally this is called once per frame). This problem is most
likely due to run criteria/fixed timesteps or consuming events
conditionally. See the Events documentation for
more information.

when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
cart pushed a commit that referenced this pull request Nov 30, 2022
@alice-i-cecile @cart
Remove warning about missed events due to false positives (#6730)
c7ad98a 
# Objective

- Reverts #5730.
- Fixes #6173, fixes #6596.

## Solution

Remove the warning entirely.

## Changelog

You will no longer be spammed about

> Missed 31 `bevy_input::mouse::MouseMotion` events. Consider
reading from the `EventReader` more often (generally the best
solution) or calling Events::update() less frequently
(normally this is called once per frame). This problem is most
likely due to run criteria/fixed timesteps or consuming events
conditionally. See the Events documentation for
more information.

when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
@CatThingy CatThingy mentioned this pull request Jan 4, 2023
Open
archsolar pushed a commit to archsolar/bevy that referenced this pull request Jan 20, 2023
@alice-i-cecile @archsolar
Remove warning about missed events due to false positives (bevyengine…
b9dd4aa 
…#6730)

- Reverts bevyengine#5730.
- Fixes bevyengine#6173, fixes bevyengine#6596.

Remove the warning entirely.

You will no longer be spammed about

> Missed 31 `bevy_input::mouse::MouseMotion` events. Consider
reading from the `EventReader` more often (generally the best
solution) or calling Events::update() less frequently
(normally this is called once per frame). This problem is most
likely due to run criteria/fixed timesteps or consuming events
conditionally. See the Events documentation for
more information.

when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
archsolar pushed a commit to archsolar/bevy that referenced this pull request Jan 20, 2023
@alice-i-cecile @archsolar
Remove warning about missed events due to false positives (bevyengine…
183a803 
…#6730)

# Objective

- Reverts bevyengine#5730.
- Fixes bevyengine#6173, fixes bevyengine#6596.

## Solution

Remove the warning entirely.

## Changelog

You will no longer be spammed about

> Missed 31 `bevy_input::mouse::MouseMotion` events. Consider
reading from the `EventReader` more often (generally the best
solution) or calling Events::update() less frequently
(normally this is called once per frame). This problem is most
likely due to run criteria/fixed timesteps or consuming events
conditionally. See the Events documentation for
more information.

when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@Aceeri @cart @ItsDoot
Warning message for missing events (bevyengine#5730)
fb80a29 
# Objective
- Reduce debugging burden when using events by telling user when they missed an event.

## Solution

Co-authored-by: Carter Anderson <[email protected]>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@alice-i-cecile @ItsDoot
Remove warning about missed events due to false positives (bevyengine…
307059f 
…#6730)

# Objective

- Reverts bevyengine#5730.
- Fixes bevyengine#6173, fixes bevyengine#6596.

## Solution

Remove the warning entirely.

## Changelog

You will no longer be spammed about

> Missed 31 `bevy_input::mouse::MouseMotion` events. Consider
reading from the `EventReader` more often (generally the best
solution) or calling Events::update() less frequently
(normally this is called once per frame). This problem is most
likely due to run criteria/fixed timesteps or consuming events
conditionally. See the Events documentation for
more information.

when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
@urben1680 urben1680 mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf left review comments

@cart cart cart approved these changes

Assignees
No one assigned
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aceeri @mockersf @cart @alice-i-cecile