Draft: Don't crash on symlinks that point outside asset_io.root_path. #5690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
pathdiff
crate (which apparently is foraged from the Rust stdlib relpath calculating implementation, but never stabilized and was replaced with simplerstrip_prefix
!), we can prevent Bevy from panicking and crashing, but this isn't an ideal solution, as it still doesn't understand that the assets loaded from outside the asset directory path are the same as the ones inside, so the filesystem watching functionality doesn't update the right asset. For assets that are originally meant to be picked up dynamically via filesystem watching events, it somehow works, but this is almost never the case.