Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Don't crash on symlinks that point outside asset_io.root_path. #5690

Closed
wants to merge 1 commit into from

Conversation

golddranks
Copy link

Objective

Solution

  • Using the pathdiff crate (which apparently is foraged from the Rust stdlib relpath calculating implementation, but never stabilized and was replaced with simpler strip_prefix!), we can prevent Bevy from panicking and crashing, but this isn't an ideal solution, as it still doesn't understand that the assets loaded from outside the asset directory path are the same as the ones inside, so the filesystem watching functionality doesn't update the right asset. For assets that are originally meant to be picked up dynamically via filesystem watching events, it somehow works, but this is almost never the case.

@Nilirad Nilirad added A-Assets Load files from disk to use for things like images, models, and sounds C-Dependencies A change to the crates that Bevy depends on labels Aug 14, 2022
@bas-ie
Copy link
Contributor

bas-ie commented Oct 5, 2024

Backlog cleanup: lack of activity. In other PRs, symlinks have been discussed and the general sense seems to be that we should avoid symlinks rather than cater for them.

@bas-ie bas-ie closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Dependencies A change to the crates that Bevy depends on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants