[Merged by Bors] - Added reflect/from reflect impls for NonZero integer types #5556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
approved these changes
Aug 3, 2022
Comment on lines
+46
to
+57
| impl_reflect_value!(NonZeroI128(Debug, Hash, PartialEq, Serialize, Deserialize)); | ||
| impl_reflect_value!(NonZeroU128(Debug, Hash, PartialEq, Serialize, Deserialize)); | ||
| impl_reflect_value!(NonZeroIsize(Debug, Hash, PartialEq, Serialize, Deserialize)); | ||
| impl_reflect_value!(NonZeroUsize(Debug, Hash, PartialEq, Serialize, Deserialize)); | ||
| impl_reflect_value!(NonZeroI64(Debug, Hash, PartialEq, Serialize, Deserialize)); | ||
| impl_reflect_value!(NonZeroU64(Debug, Hash, PartialEq, Serialize, Deserialize)); | ||
| impl_reflect_value!(NonZeroU32(Debug, Hash, PartialEq, Serialize, Deserialize)); | ||
| impl_reflect_value!(NonZeroI32(Debug, Hash, PartialEq, Serialize, Deserialize)); | ||
| impl_reflect_value!(NonZeroI16(Debug, Hash, PartialEq, Serialize, Deserialize)); | ||
| impl_reflect_value!(NonZeroU16(Debug, Hash, PartialEq, Serialize, Deserialize)); | ||
| impl_reflect_value!(NonZeroU8(Debug, Hash, PartialEq, Serialize, Deserialize)); | ||
| impl_reflect_value!(NonZeroI8(Debug, Hash, PartialEq, Serialize, Deserialize)); |
There was a problem hiding this comment.
Nit: I’m sure this works and all, but could we add a test for at least one of these types? Ideally we'd test both Reflect and FromReflect are working.
There was a problem hiding this comment.
Ive added a single test (one assert for reflect, one for from reflect) - I can add more if needed however.
mockersf
approved these changes
Aug 3, 2022
alice-i-cecile
added
A-Reflection
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 4, 2022
# Objective Add reflect/from reflect impls for NonZero integer types. I'm guessing these haven't been added yet because no one has needed them as of yet.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
maccesch
pushed a commit
to Synphonyte/bevy
that referenced
this pull request
Aug 5, 2022
…e#5556) # Objective Add reflect/from reflect impls for NonZero integer types. I'm guessing these haven't been added yet because no one has needed them as of yet.
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
…e#5556) # Objective Add reflect/from reflect impls for NonZero integer types. I'm guessing these haven't been added yet because no one has needed them as of yet.
inodentry
pushed a commit
to BroovyJammy/bevy
that referenced
this pull request
Aug 19, 2022
…e#5556) # Objective Add reflect/from reflect impls for NonZero integer types. I'm guessing these haven't been added yet because no one has needed them as of yet.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…e#5556) # Objective Add reflect/from reflect impls for NonZero integer types. I'm guessing these haven't been added yet because no one has needed them as of yet.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…e#5556) # Objective Add reflect/from reflect impls for NonZero integer types. I'm guessing these haven't been added yet because no one has needed them as of yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add reflect/from reflect impls for NonZero integer types. I'm guessing these haven't been added yet because no one has needed them as of yet.