Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - don't render completely transparent UI nodes #5537

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - don't render completely transparent UI nodes #5537

wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Aug 1, 2022

Objective

  • I often have UI nodes that are completely transparent and just for organisation
  • Don't render them
  • I doesn't bring a lot of improvements, but it doesn't add a lot of complexity either

@mockersf mockersf added the A-UI Graphical user interfaces, styles, layouts, and widgets label Aug 1, 2022
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times labels Aug 1, 2022
Weibye
Weibye approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@Weibye Weibye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 1, 2022
IceSentry
IceSentry approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it with a few examples and it seemed to work as expected.

LGTM

@cart
Copy link
Member

cart commented Aug 8, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 8, 2022
@mockersf
don't render completely transparent UI nodes (#5537)
b80636b 
# Objective

- I often have UI nodes that are completely transparent and just for organisation
- Don't render them
- I doesn't bring a lot of improvements, but it doesn't add a lot of complexity either
@bors
Copy link
Contributor

bors bot commented Aug 8, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title don't render completely transparent UI nodes [Merged by Bors] - don't render completely transparent UI nodes Aug 8, 2022
@bors bors bot closed this Aug 8, 2022
inodentry pushed a commit to BroovyJammy/bevy that referenced this pull request Aug 19, 2022
@mockersf @inodentry
don't render completely transparent UI nodes (bevyengine#5537)
f5daa43 
# Objective

- I often have UI nodes that are completely transparent and just for organisation
- Don't render them
- I doesn't bring a lot of improvements, but it doesn't add a lot of complexity either
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
@mockersf @maccesch
don't render completely transparent UI nodes (bevyengine#5537)
0583ad9 
# Objective

- I often have UI nodes that are completely transparent and just for organisation
- Don't render them
- I doesn't bring a lot of improvements, but it doesn't add a lot of complexity either
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@mockersf @james7132
don't render completely transparent UI nodes (bevyengine#5537)
88ca052 
# Objective

- I often have UI nodes that are completely transparent and just for organisation
- Don't render them
- I doesn't bring a lot of improvements, but it doesn't add a lot of complexity either
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
don't render completely transparent UI nodes (bevyengine#5537)
96500f4 
# Objective

- I often have UI nodes that are completely transparent and just for organisation
- Don't render them
- I doesn't bring a lot of improvements, but it doesn't add a lot of complexity either
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

@Weibye Weibye Weibye approved these changes

@nicopap nicopap nicopap approved these changes

@inodentry inodentry inodentry approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Performance A change motivated by improving speed, memory usage or compile times S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mockersf @cart @alice-i-cecile @IceSentry @Weibye @nicopap @inodentry