Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove unused code in game of life shader #5349

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Remove unused code in game of life shader #5349

wants to merge 1 commit into from

Conversation

NiklasEi
Copy link
Member

Objective

  • Make game_of_life.wgsl easier to read and understand

Solution

  • Remove unused code in the shader
    • location_f32 was unused in init
    • color was unused in update

@NiklasEi NiklasEi added the C-Examples An addition or correction to our examples label Jul 17, 2022
@superdump superdump added the A-Rendering Drawing game state to the screen label Jul 17, 2022
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 17, 2022
@superdump
Copy link
Contributor

bors r+

bors bot pushed a commit that referenced this pull request Jul 17, 2022
@NiklasEi
Remove unused code in game of life shader (#5349)
128e51b 
# Objective

- Make `game_of_life.wgsl` easier to read and understand

## Solution

- Remove unused code in the shader
    - `location_f32` was unused in `init`
    - `color` was unused in `update`
@bors
Copy link
Contributor

bors bot commented Jul 17, 2022

Build failed:

@superdump
Copy link
Contributor

bors retry

bors bot pushed a commit that referenced this pull request Jul 17, 2022
@NiklasEi
Remove unused code in game of life shader (#5349)
7ff48e5 
# Objective

- Make `game_of_life.wgsl` easier to read and understand

## Solution

- Remove unused code in the shader
    - `location_f32` was unused in `init`
    - `color` was unused in `update`
@bors
Copy link
Contributor

bors bot commented Jul 17, 2022

Build failed:

@superdump
Copy link
Contributor

bors retry

bors bot pushed a commit that referenced this pull request Jul 17, 2022
@NiklasEi
Remove unused code in game of life shader (#5349)
4224534 
# Objective

- Make `game_of_life.wgsl` easier to read and understand

## Solution

- Remove unused code in the shader
    - `location_f32` was unused in `init`
    - `color` was unused in `update`
@bors
Copy link
Contributor

bors bot commented Jul 17, 2022

Build failed:

@superdump
Copy link
Contributor

bors retry

bors bot pushed a commit that referenced this pull request Jul 17, 2022
@NiklasEi
Remove unused code in game of life shader (#5349)
af4cca2 
# Objective

- Make `game_of_life.wgsl` easier to read and understand

## Solution

- Remove unused code in the shader
    - `location_f32` was unused in `init`
    - `color` was unused in `update`
@bors
Copy link
Contributor

bors bot commented Jul 17, 2022

Build failed:

@superdump
Copy link
Contributor

sigh

@superdump
Copy link
Contributor

bors retry

bors bot pushed a commit that referenced this pull request Jul 17, 2022
@NiklasEi
Remove unused code in game of life shader (#5349)
2b93ab5 
# Objective

- Make `game_of_life.wgsl` easier to read and understand

## Solution

- Remove unused code in the shader
    - `location_f32` was unused in `init`
    - `color` was unused in `update`
@bors
Copy link
Contributor

bors bot commented Jul 17, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove unused code in game of life shader [Merged by Bors] - Remove unused code in game of life shader Jul 17, 2022
@bors bors bot closed this Jul 17, 2022
@NiklasEi NiklasEi deleted the cleanup_game_of_life branch July 17, 2022 16:25
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
@NiklasEi @inodentry
Remove unused code in game of life shader (bevyengine#5349)
808e3bd 
# Objective

- Make `game_of_life.wgsl` easier to read and understand

## Solution

- Remove unused code in the shader
    - `location_f32` was unused in `init`
    - `color` was unused in `update`
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@NiklasEi @james7132
Remove unused code in game of life shader (bevyengine#5349)
3a96f35 
# Objective

- Make `game_of_life.wgsl` easier to read and understand

## Solution

- Remove unused code in the shader
    - `location_f32` was unused in `init`
    - `color` was unused in `update`
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@NiklasEi @ItsDoot
Remove unused code in game of life shader (bevyengine#5349)
438ee82 
# Objective

- Make `game_of_life.wgsl` easier to read and understand

## Solution

- Remove unused code in the shader
    - `location_f32` was unused in `init`
    - `color` was unused in `update`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NiklasEi @superdump @mockersf