[Merged by Bors] - add a SpatialBundle with visibility and transform components #5344
Conversation
alice-i-cecile
added
C-Usability
|
@IceSentry this isn't a breaking change but will need to go in the migration guide. |
|
@alice-i-cecile about your review, I would prefer to keep as is and have a followup PR changing the style everywhere |
|
Alright, I'm on board. Can you make a quick issue so we don't forget? |
| /// * To show or hide an entity, you should set its [`Visibility`]. | ||
| /// * To get the computed visibility of an entity, you should get its [`ComputedVisibility`]. | ||
| /// * To place or move an entity, you should set its [`Transform`]. | ||
| /// * To get the global position of an entity, you should get its [`GlobalTransform`]. |
There was a problem hiding this comment.
Not just global position, but global transform. :) Maybe note that it is only valid for the current frame after transform propagation has been run?
There was a problem hiding this comment.
On the one hand, this is useful information. On the other hand, idk if we should be duplicating it across every bundle that includes GlobalTransform.
There was a problem hiding this comment.
I do agree that "global transform" is preferable to "global position".
| /// * [`Transform`] and [`GlobalTransform`], which describe the position of an entity | ||
| /// | ||
| /// * To show or hide an entity, you should set its [`Visibility`]. | ||
| /// * To get the computed visibility of an entity, you should get its [`ComputedVisibility`]. |
There was a problem hiding this comment.
Maybe note that it is only valid after the visibility systems have been run? (check_visibility and visibility_propagate, I think.)
There was a problem hiding this comment.
On the one hand, this is useful information. On the other hand, idk if we should be duplicating it across every bundle that includes ComputedVisibility. ComputedVisibility does have this "label dependency" information encoded in the relevant fields already. But it is probably worth also including that in the main ComputedVisibility docs.
There was a problem hiding this comment.
(Not something I think we should block on here though)
Co-authored-by: Robert Swain <[email protected]>
mockersf
changed the title
|
bors r+ |
# Objective - Help user when they need to add both a `TransformBundle` and a `VisibilityBundle` ## Solution - Add a `SpatialBundle` adding all components
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
…ine#5344) # Objective - Help user when they need to add both a `TransformBundle` and a `VisibilityBundle` ## Solution - Add a `SpatialBundle` adding all components
…ine#5344) # Objective - Help user when they need to add both a `TransformBundle` and a `VisibilityBundle` ## Solution - Add a `SpatialBundle` adding all components
…ine#5344) # Objective - Help user when they need to add both a `TransformBundle` and a `VisibilityBundle` ## Solution - Add a `SpatialBundle` adding all components
Objective
TransformBundleand aVisibilityBundleSolution
SpatialBundleadding all components