Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - can specify chrome tracing file #4618

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - can specify chrome tracing file #4618

wants to merge 3 commits into from

Conversation

mockersf
Copy link
Member

Objective

  • I want to have the trace file at a predictable path

Solution

  • Adds an environment variable that is used as the path when it's set

@alice-i-cecile alice-i-cecile added A-Log C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Build-System Related to build systems or continuous integration labels Apr 27, 2022
alice-i-cecile
alice-i-cecile approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍🏽

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 27, 2022
@alice-i-cecile alice-i-cecile removed the S-Needs-Triage This issue needs to be labelled label Apr 27, 2022
@superdump
Copy link
Contributor

bors r+

bors bot pushed a commit that referenced this pull request May 3, 2022
@mockersf
can specify chrome tracing file (#4618)
b5feb9a 
# Objective

- I want to have the trace file at a predictable path

## Solution

- Adds an environment variable that is used as the path when it's set
@bors
Copy link
Contributor

bors bot commented May 3, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title can specify chrome tracing file [Merged by Bors] - can specify chrome tracing file May 3, 2022
@bors bors bot closed this May 3, 2022
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
@mockersf @exjam
can specify chrome tracing file (bevyengine#4618)
b0f087d 
# Objective

- I want to have the trace file at a predictable path

## Solution

- Adds an environment variable that is used as the path when it's set
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
can specify chrome tracing file (bevyengine#4618)
87767cb 
# Objective

- I want to have the trace file at a predictable path

## Solution

- Adds an environment variable that is used as the path when it's set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @superdump @alice-i-cecile