Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - create font atlas that can contains fonts of any size #3592

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - create font atlas that can contains fonts of any size #3592

wants to merge 4 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jan 8, 2022

Objective

  • Bevy currently panics when displaying text with a very big font size (with font size greater than 400, the glyph would have a width or height greater than 512)
thread 'main' panicked at 'Fatal error when processing text: failed to add glyph to newly-created atlas GlyphId(514).', crates/bevy_ui/src/widget/text.rs:118:21

Solution

  • Create font atlas that scales up with the size of the glyphs

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jan 8, 2022
@james7132 james7132 added A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior P-Crash A sudden unexpected crash and removed S-Needs-Triage This issue needs to be labelled labels Jan 8, 2022
sixfold-origami
sixfold-origami approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@sixfold-origami sixfold-origami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

tim-blackbird
tim-blackbird approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@tim-blackbird tim-blackbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I would like a comment on the calculation for containing though.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 17, 2022
@alice-i-cecile alice-i-cecile removed the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 30, 2022
@mockersf @alice-i-cecile
improve comment
600f41d 
Co-authored-by: Alice Cecile <[email protected]>
@alice-i-cecile
Copy link
Member

bors r+

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 1, 2022
bors bot pushed a commit that referenced this pull request Jun 1, 2022
@mockersf
create font atlas that can contains fonts of any size (#3592)
a16ffe6 
# Objective

- Bevy currently panics when displaying text with a *very* big font size  (with font size greater than 400, the glyph would have a width or height greater than 512)
```
thread 'main' panicked at 'Fatal error when processing text: failed to add glyph to newly-created atlas GlyphId(514).', crates/bevy_ui/src/widget/text.rs:118:21
```

## Solution

- Create font atlas that scales up with the size of the glyphs
@bors
Copy link
Contributor

bors bot commented Jun 1, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title create font atlas that can contains fonts of any size [Merged by Bors] - create font atlas that can contains fonts of any size Jun 1, 2022
@bors bors bot closed this Jun 1, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Jun 7, 2022
@mockersf @james7132
create font atlas that can contains fonts of any size (bevyengine#3592)
4918ad6 
# Objective

- Bevy currently panics when displaying text with a *very* big font size  (with font size greater than 400, the glyph would have a width or height greater than 512)
```
thread 'main' panicked at 'Fatal error when processing text: failed to add glyph to newly-created atlas GlyphId(514).', crates/bevy_ui/src/widget/text.rs:118:21
```

## Solution

- Create font atlas that scales up with the size of the glyphs
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
create font atlas that can contains fonts of any size (bevyengine#3592)
ae6e3db 
# Objective

- Bevy currently panics when displaying text with a *very* big font size  (with font size greater than 400, the glyph would have a width or height greater than 512)
```
thread 'main' panicked at 'Fatal error when processing text: failed to add glyph to newly-created atlas GlyphId(514).', crates/bevy_ui/src/widget/text.rs:118:21
```

## Solution

- Create font atlas that scales up with the size of the glyphs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile requested changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@sixfold-origami sixfold-origami sixfold-origami approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior P-Crash A sudden unexpected crash S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mockersf @alice-i-cecile @sixfold-origami @tim-blackbird @james7132