-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webp support to texture loader #2600
Conversation
I think there are places where we document our features We need to do this for this one (we should also mention that it uses native libraries, so will be more difficult to build for someone) |
@DJMcNab Thanks! Updated changelog and doc as suggested. |
CHANGELOG.md
Outdated
@@ -92,6 +92,7 @@ current changes on git with [previous release tags][git_tag_comparison]. | |||
- [Added `set_minimized` and `set_position` to `Window`][1292] | |||
- [Example for 2D Frustum Culling][1503] | |||
- [Add remove resource to commands][1478] | |||
- [Add webp as a supported texture format (C compiler required)][2600] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats the Changelog of the already released 0.5
0.6 does not have a Changelog yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
Didn't find an easy answer with a quick read, is the link to libwebp static or dynamic?
|
@mockersf It's statically linked, regarding license, could you please point me to where I should put up a notice, code doc or feature doc? Personally, I feel it belongs to a more detailed license section in readme.md btw, libwebp has a github mirror repo |
we don't have a good place yet for that, I guess for now mentioning this in #1885 when it gets merged should be enough |
So, this PR is stale ... but here is what could happen given the status in current bevy. From looking at the source code, I see that we are enumerating WebP (incl many others) in However, there is no actual asset loader enablement for it (and a few of the other formats listed there btw). It is lacking here: https://github.com/bevyengine/bevy/blob/main/crates/bevy_render/src/texture/image_texture_loader.rs#L20 For anyone wanting to pick this up, you could look at the places linked above, as well as the code that was in this PR, for reference. It seems like it should be relatively straighforward to bring this up to date to current bevy. |
This has been superceded by #8220. |
Objective
webp
Solution