[Merged by Bors] - fix re-adding a plugin to a plugin group #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
force-pushed
the
plugin-disable-readd
branch
from
c110e48 to
a2fa954
Compare
|
I'm curious, is this the best behavior here? Edit: I could be wrong, and there could be a valid use case, I just can't personally think of one. 😅 |
|
The error can happen when re-adding a plugin with a new configuration. To do that you would do: App::build()
.add_plugin_group_with(PluginGroup, |group| {
group.disable::<PluginA>()
.add_after::< PluginA, _>(PluginA {
// custom values here
})
})but that didn't work before this PR: it marked |
|
Maybe it could issue a warning when replacing a pluging that is not disabled? |
I'm in favor of this behavior if possible. |
alice-i-cecile
approved these changes
Apr 29, 2021
|
added a |
NiklasEi
reviewed
Apr 30, 2021
NiklasEi
approved these changes
May 1, 2021
mockersf
force-pushed
the
plugin-disable-readd
branch
from
2495686 to
891cef0
Compare
mockersf
force-pushed
the
plugin-disable-readd
branch
from
891cef0 to
3cb9b4f
Compare
cart
added
the
S-Pre-Relicense
mockersf
force-pushed
the
plugin-disable-readd
branch
from
3cb9b4f to
405f5a3
Compare
mockersf
removed
the
S-Pre-Relicense
mockersf
force-pushed
the
plugin-disable-readd
branch
2 times, most recently
from
5c6ab13 to
9cd8d0f
Compare
mockersf
force-pushed
the
plugin-disable-readd
branch
from
9cd8d0f to
5250fac
Compare
mockersf
force-pushed
the
plugin-disable-readd
branch
from
5250fac to
86368c4
Compare
mockersf
force-pushed
the
plugin-disable-readd
branch
from
86368c4 to
ead2b23
Compare
alice-i-cecile
added
the
S-Ready-For-Final-Review
Co-Authored-By: Niklas Eicker <[email protected]>
mockersf
force-pushed
the
plugin-disable-readd
branch
from
ead2b23 to
ebe230e
Compare
bors bot
pushed a commit
that referenced
this pull request
May 9, 2022
In a `PluginGroupBuilder`, when adding a plugin that was already in the group (potentially disabled), it was then added twice to the app builder when calling `finish`. As the plugin is kept in an `HashMap`, it is not possible to have the same plugins twice with different configuration. This PR updates the order of the plugin group so that each plugin is present only once. Co-authored-by: François <[email protected]>
bors
bot
changed the title
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
May 10, 2022
In a `PluginGroupBuilder`, when adding a plugin that was already in the group (potentially disabled), it was then added twice to the app builder when calling `finish`. As the plugin is kept in an `HashMap`, it is not possible to have the same plugins twice with different configuration. This PR updates the order of the plugin group so that each plugin is present only once. Co-authored-by: François <[email protected]>
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
In a `PluginGroupBuilder`, when adding a plugin that was already in the group (potentially disabled), it was then added twice to the app builder when calling `finish`. As the plugin is kept in an `HashMap`, it is not possible to have the same plugins twice with different configuration. This PR updates the order of the plugin group so that each plugin is present only once. Co-authored-by: François <[email protected]>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
In a `PluginGroupBuilder`, when adding a plugin that was already in the group (potentially disabled), it was then added twice to the app builder when calling `finish`. As the plugin is kept in an `HashMap`, it is not possible to have the same plugins twice with different configuration. This PR updates the order of the plugin group so that each plugin is present only once. Co-authored-by: François <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a
PluginGroupBuilder, when adding a plugin that was already in the group (potentially disabled), it was then added twice to the app builder when callingfinish. As the plugin is kept in anHashMap, it is not possible to have the same plugins twice with different configuration.This PR updates the order of the plugin group so that each plugin is present only once.